Skip to content

Misc cleanups

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22btrfs: assume that bio_ret is always valid in submit_extent_pagefs/btrfs/extent_io.c+5 -50 replies
2/22btrfs: assume that prev_em_start is always valid in __do_readpagefs/btrfs/extent_io.c+6 -32 replies
3/22btrfs: remove redundant variable in __do_readpagefs/btrfs/extent_io.c+1 -30 replies
4/22btrfs: cleanup merging conditions in submit_extent_pagefs/btrfs/extent_io.c+9 -170 replies
5/22btrfs: document more parameters of submit_extent_pagefs/btrfs/extent_io.c+12 -00 replies
6/22btrfs: drop fs_info parameter from tree_mod_log_set_node_keyfs/btrfs/ctree.c+8 -110 replies
7/22btrfs: drop fs_info parameter from tree_mod_log_insert_movefs/btrfs/ctree.c+10 -130 replies
8/22btrfs: drop fs_info parameter from tree_mod_log_insert_keyfs/btrfs/ctree.c+12 -150 replies
9/22btrfs: drop fs_info parameter from tree_mod_log_free_ebfs/btrfs/ctree.c+6 -90 replies
10/22btrfs: drop fs_info parameter from tree_mod_log_free_ebfs/btrfs/ctree.c+4 -70 replies
11/22btrfs: drop unused fs_info parameter from tree_mod_log_eb_movefs/btrfs/ctree.c+6 -70 replies
12/22btrfs: embed tree_mod_move structure to tree_mod_elemfs/btrfs/ctree.c+4 -60 replies
13/22btrfs: drop fs_info parameter from __tree_mod_log_oldest_rootfs/btrfs/ctree.c+5 -60 replies
14/22btrfs: remove trivial locking wrappers of tree mod logfs/btrfs/ctree.c+19 -392 replies
15/22btrfs: kill trivial wrapper tree_mod_log_eb_movefs/btrfs/ctree.c+12 -150 replies
16/22btrfs: kill tree_mod_log_set_node_key helperfs/btrfs/ctree.c+17 -150 replies
17/22btrfs: kill tree_mod_log_set_root_pointer helperfs/btrfs/ctree.c+7 -131 reply
18/22btrfs: move allocation after simple tests in tree_mod_log_insert_keyfs/btrfs/ctree.c+3 -52 replies
19/22btrfs: separate types for submit_bio_start and submit_bio_donefs/btrfs/disk-io.c fs/btrfs/disk-io.h fs/btrfs/extent_io.h+15 -60 replies
20/22btrfs: remove unused parameters from extent_submit_bio_start_tfs/btrfs/disk-io.c fs/btrfs/extent_io.h fs/btrfs/inode.c+2 -70 replies
21/22btrfs: remove unused parameters from extent_submit_bio_done_tfs/btrfs/disk-io.c fs/btrfs/extent_io.h fs/btrfs/inode.c+4 -80 replies
22/22btrfs: rename submit callbacks and drop double underscoresfs/btrfs/disk-io.c fs/btrfs/inode.c+15 -160 replies

Reviews trailers per patch

2 of 22 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/22
2/22
3/22
4/22
5/22
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22R-b
15/22
16/22
17/22R-b
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/22] Misc cleanups

Cleanups that have piled over the time. The "very important" unused argument removals, some renaming and simplifications.

The effects on stack consumption are not huge, but still measurable:

ctree.c:tree_mod_log_insert_key +16 (48 -> 64)

ctree.c:tree_mod_log_insert_move               -8 (104 -> 96)
ctree.c:insert_ptr.isra.24                     -8 (80 -> 72)
ctree.c:del_ptr.isra.25                        -8 (96 -> 88)
ctree.c:btrfs_old_root_level                   -8 (32 -> 24)
ctree.c:btrfs_set_item_key_safe                -8 (88 -> 80)

extent_io.c:submit_extent_page -40 (112 -> 72)

David Sterba (22):
btrfs: assume that bio_ret is always valid in submit_extent_page
btrfs: assume that prev_em_start is always valid in __do_readpage
btrfs: remove redundant variable in __do_readpage
btrfs: cleanup merging conditions in submit_extent_page
btrfs: document more parameters of submit_extent_page
btrfs: drop fs_info parameter from tree_mod_log_set_node_key
btrfs: drop fs_info parameter from tree_mod_log_insert_move
btrfs: drop fs_info parameter from tree_mod_log_insert_key
btrfs: drop fs_info parameter from tree_mod_log_free_eb
btrfs: drop fs_info parameter from tree_mod_log_free_eb
btrfs: drop unused fs_info parameter from tree_mod_log_eb_move
btrfs: embed tree_mod_move structure to tree_mod_elem
btrfs: drop fs_info parameter from __tree_mod_log_oldest_root
btrfs: remove trivial locking wrappers of tree mod log
btrfs: kill trivial wrapper tree_mod_log_eb_move
btrfs: kill tree_mod_log_set_node_key helper
btrfs: kill tree_mod_log_set_root_pointer helper
btrfs: move allocation after simple tests in tree_mod_log_insert_key
btrfs: separate types for submit_bio_start and submit_bio_done
btrfs: remove unused parameters from extent_submit_bio_start_t
btrfs: remove unused parameters from extent_submit_bio_done_t
btrfs: rename submit callbacks and drop double underscores

 fs/btrfs/ctree.c     | 234 ++++++++++++++++++++-------------------------------
 fs/btrfs/disk-io.c   |  24 +++---
 fs/btrfs/disk-io.h   |   4 +-
 fs/btrfs/extent_io.c |  61 ++++++++------
 fs/btrfs/extent_io.h |   7 ++
 fs/btrfs/inode.c     |  30 +++----
 6 files changed, 158 insertions(+), 202 deletions(-)
Signature · 1 line
2.16.2