Skip to content

shortlog: disallow left-over arguments outside repo

Martin Ågren git 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 8 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3git-shortlog.txt: reorder usagesDocumentation/git-shortlog.txt+1 -10 replies
2/3shortlog: add usage-string for stdin-readingbuiltin/shortlog.c+2 -10 replies
3/3shortlog: disallow left-over arguments outside repobuiltin/shortlog.c t/t4201-shortlog.sh+10 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] shortlog: disallow left-over arguments outside repo

This is v2 of my attempt at stopping shortlog from BUG-ing when it is used incorrectly outside a repo. Thanks Jonathan and Junio for helpful comments.

Patches 1 and 2 are identical to pu. The error message in patch 3 is now more general. The error condition on the other hand is a bit more specific, "argc > 1", to better match the intention and commit message.

Martin

Martin Ågren (3):
git-shortlog.txt: reorder usages
shortlog: add usage-string for stdin-reading
shortlog: disallow left-over arguments when run outside repo

 Documentation/git-shortlog.txt | 2 +-
 t/t4201-shortlog.sh            | 5 +++++
 builtin/shortlog.c             | 8 +++++++-
 3 files changed, 13 insertions(+), 2 deletions(-)
Signature · 1 line
2.16.2.246.ga4ee44448f