Skip to content

staging:iio:ad2s1210: Rework read/write operation for fclkin and fexin

Rodrigo Siqueira linux-iio lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Removes unnecessary switch case in the write_raw function.
- Replaces the use of goto for direct return.
- Removes definition with string.
- Removes unecessary label.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging:iio:ad2s1210: Add channel for fclkin and fexcitdrivers/staging/iio/resolver/ad2s1210.c+29 -142 replies
2/3staging:iio:ad2s1210: Add frequency handler in read_rawdrivers/staging/iio/resolver/ad2s1210.c+20 -250 replies
3/3staging:iio:ad2s1210: Add write_raw to handle frequencydrivers/staging/iio/resolver/ad2s1210.c+45 -620 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] staging:iio:ad2s1210: Rework read/write operation for fclkin and fexin

This patchset changes the way that frequency of clock input (fclkin) and the excitation frequency (fexcit) are exposed to the userspace. The original code uses the IIO_DEVICE_ATTR to export the configuration of fclkin and fexcit to the userspace which is not in agreement with the current ABI. This patchset adds one channel per clock configuration, updating the read_raw function by adding a handler for the new channels, and introduces the write_raw function. Furthermore, this patchset removes the legacy code responsible for the read and write operation related to fclkin and fexcit. Finally, this patchset uses parts of the original code for handling frequency configuration as an attempt to avoid problems.

Changes in v2:
- Removes unnecessary switch case in the write_raw function.
- Replaces the use of goto for direct return.
- Removes definition with string.
- Removes unecessary label.

Rodrigo Siqueira (3):
staging:iio:ad2s1210: Add channel for fclkin and fexcit staging:iio:ad2s1210: Add frequency handler in read_raw staging:iio:ad2s1210: Add write_raw to handle frequency

 drivers/staging/iio/resolver/ad2s1210.c | 191 +++++++++++++++-----------------
 1 file changed, 92 insertions(+), 99 deletions(-)
Signature · 1 line
2.16.2