Skip to content

vti4, ip_tunnel: Fixes for MTU assignment and validation

Stefano Brivio netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3vti4: Don't count header length twice on tunnel setupnet/ipv4/ip_vti.c+0 -10 replies
2/3ip_tunnel: Clamp MTU to bounds on new linknet/ipv4/ip_tunnel.c+7 -10 replies
3/3vti4: Don't override MTU passed on link creation via IFLA_MTUnet/ipv4/ip_vti.c+0 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSabrina Dubroca
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] vti4, ip_tunnel: Fixes for MTU assignment and validation

Patch 1/3 re-introduces a fix to ensure that default MTU on new link is not lowered unnecessarily because of double counting of headers. This fix was originally introduced in 2014 and got lost in a merge commit shortly afterwards.

Patches 2/3 and 3/3 ensure that MTU passed from userspace on link creation is taken into account and also properly validated.

Stefano Brivio (3):
vti4: Don't count header length twice on tunnel setup
ip_tunnel: Clamp MTU to bounds on new link
vti4: Don't override MTU passed on link creation via IFLA_MTU

 net/ipv4/ip_tunnel.c | 8 +++++++-
 net/ipv4/ip_vti.c    | 2 --
 2 files changed, 7 insertions(+), 3 deletions(-)
Signature · 1 line
2.15.1