Skip to content

net/sched: fix NULL dereference in the error path of .init()

Davide Caratti netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net/sched: fix NULL dereference in the error path of tcf_vlan_init()net/sched/act_vlan.c+2 -10 replies
2/5net/sched: fix NULL dereference in the error path of tcf_csum_init()net/sched/act_csum.c+2 -11 reply
3/5net/sched: fix NULL dereference in the error path of tunnel_key_init()net/sched/act_tunnel_key.c+5 -41 reply
4/5net/sched: fix NULL dereference in the error path of tcf_sample_init()net/sched/act_sample.c+2 -11 reply
5/5net/sched: fix NULL dereference on the error path of tcf_skbmod_init()net/sched/act_skbmod.c+2 -11 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoManish Kurup
1/5A-b A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/5] net/sched: fix NULL dereference in the error path of .init()

with several TC actions it's possible to see NULL pointer dereference, when the .init() function calls tcf_idr_alloc(), fails at some point and then calls tcf_idr_release(): this series fixes all them introducing non-NULL tests in the .cleanup() function.

Davide Caratti (5):
net/sched: fix NULL dereference in the error path of tcf_vlan_init() net/sched: fix NULL dereference in the error path of tcf_csum_init() net/sched: fix NULL dereference in the error path of tunnel_key_init() net/sched: fix NULL dereference in the error path of tcf_sample_init() net/sched: fix NULL dereference on the error path of tcf_skbmod_init()

 net/sched/act_csum.c       | 3 ++-
 net/sched/act_sample.c     | 3 ++-
 net/sched/act_skbmod.c     | 3 ++-
 net/sched/act_tunnel_key.c | 9 +++++----
 net/sched/act_vlan.c       | 3 ++-
 5 files changed, 13 insertions(+), 8 deletions(-)
Signature · 1 line
2.14.3