Skip to content

HID: alps: Fix some bugs and improve code around 't4_read_write_register()'

Christophe JAILLET kernel-janitors linux-input lkml 1 version Applied

Status from this message: Queued for 4.18, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4HID: alps: Report an error if we receive invalid data in 't4_read_write_register()'drivers/hid/hid-alps.c+2 -00 replies
2/4HID: alps: Save a memory allocation in 't4_read_write_register()' when writing datadrivers/hid/hid-alps.c+2 -20 replies
3/4HID: alps: Check errors returned by 't4_read_write_register()'drivers/hid/hid-alps.c+18 -00 replies
4/4HID: alps: Fix some style in 't4_read_write_register()'drivers/hid/hid-alps.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] HID: alps: Fix some bugs and improve code around 't4_read_write_register()'

All is said in the subject and below.

These patches are untested. Especially, patch 1 slightly changes the behavior of 't4_read_write_register()'.
This looks logical to me, but please, review it carefully.

Christophe JAILLET (4):
HID: alps: Report an error if we receive invalid data in

    't4_read_write_register()'

HID: alps: Save a memory allocation in 't4_read_write_register()' when
writing data
HID: alps: Check errors returned by 't4_read_write_register()'
HID: alps: Fix some style in 't4_read_write_register()'

 drivers/hid/hid-alps.c | 27 ++++++++++++++++++++++-----
 1 file changed, 22 insertions(+), 5 deletions(-)
Signature · 1 line
2.14.1

Read the cover letter in its thread