Skip to content

Add support to MT6323 RTC and its power device

[email protected] linux-arm-kernel linux-devicetree linux-mediatek linux-pm linux-rtc lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 5 repliesIn review
  2. v116 patches 27 repliesSuperseded

Changes in v2 from the cover letter

- The changes must be relative to the below tree since one critial patch for the rtc-mt6397.c the series depends on was being applied into the tree. Otherwise, for example, if the series are applied on the top of [1], a build error must happen due to an implicit declaration of function 'irq_create_mapping' as kbuild test robot was reporting in [2].

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17dt-bindings: power: reset: mt6323: add bindings for MT6323 power controllerDocumentation/devicetree/bindings/power/reset/mt6323-poweroff.txt+20 -02 replies
2/17dt-bindings: rtc: mt6397: add bindings for MediaTek PMIC based RTCDocumentation/devicetree/bindings/rtc/rtc-mt6397.txt+29 -01 reply
3/17dt-bindings: mfd: mt6397: add a description for MT6323 RTCDocumentation/devicetree/bindings/mfd/mt6397.txt+3 -10 replies
4/17dt-bindings: mfd: mt6397: add a description for MT6323 power controllerDocumentation/devicetree/bindings/mfd/mt6397.txt+6 -00 replies
5/17mfd: mt6397: add MT6323 RTC support into MT6397 driverdrivers/mfd/mt6397-core.c+15 -10 replies
6/17mfd: mt6397: add support for MT6323 power controller into MT6397 driverdrivers/mfd/mt6397-core.c+12 -00 replies
7/17mfd: mt6397: reuse DEFINE_RES_* helpersdrivers/mfd/mt6397-core.c+2 -100 replies
8/17rtc: mt6397: add MT6323 support to RTC driverdrivers/rtc/rtc-mt6397.c+1 -00 replies
9/17rtc: mt6397: replace a poll with regmap_read_poll_timeoutdrivers/rtc/rtc-mt6397.c+11 -140 replies
10/17rtc: mt6397: remove unnecessary irq_dispose_mappingdrivers/rtc/rtc-mt6397.c+2 -50 replies
11/17rtc: mt6397: convert to use device managed functionsdrivers/rtc/rtc-mt6397.c+10 -270 replies
12/17rtc: mt6397: move the declaration into a globally visible header filedrivers/rtc/rtc-mt6397.c include/linux/mfd/mt6397/rtc.h+71 -520 replies
13/17rtc: mt6397: cleanup header files to includedrivers/rtc/rtc-mt6397.c+4 -70 replies
14/17rtc: mt6397: update license converting to using SPDX identifiersdrivers/rtc/rtc-mt6397.c+8 -120 replies
15/17power: reset: mt6323: add a driver for MT6323 power controllerdrivers/power/reset/Kconfig drivers/power/reset/Makefile drivers/power/reset/mt6323-poweroff.c +1 more+109 -02 replies
16/17MAINTAINERS: update entry for ARM/Mediatek RTC DRIVERMAINTAINERS+2 -00 replies
17/17MAINTAINERS: add an entry for MediaTek board level shutdown driverMAINTAINERS+7 -00 replies

Reviews trailers per patch

2 of 17 patches have a Reviewed-by or Acked-by.

PatchRob HerringLee Jones
1/17
2/17R-b
3/17R-b A-b
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/17] Add support to MT6323 RTC and its power device

From: Sean Wang <[email protected]>

v2:

- The changes must be relative to the below tree since one critial patch for the rtc-mt6397.c the series depends on was being applied into the tree. Otherwise, for example, if the series are applied on the top of [1], a build error must happen due to an implicit declaration of function 'irq_create_mapping' as kbuild test robot was reporting in [2].

tree : https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git
branch : mfd/ib-mfd-input-rtc-4.18

- changes since v1:
* Define the power controller as a function of MT6323 MFD.
* Refine the whole series commit message and title.
* Add tag Reviewed-by and Acked-by got from v1 result.
* Reuse use the DEFINE_RES_* helpers in mfd driver.
* Remove an overdone patch rtc: mediatek: remove unnecessary parentheses.
* Use devm_rtc_allocate_device() and rtc_register_device instead of devm_rtc_device_register.
* Have an improvement according to the license rule the SPDX notation for C header file.
* Move a file from include/linux/rtc/mt6397.h to include/linux/mfd/mt6397/rtc.h
* Refine include/linux/mfd/mt6397/rtc.h

[1] https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git
[2] http://lists.infradead.org/pipermail/linux-mediatek/2018-March/012548.html

v1:

Hi,

The series keeps to extend the capability of BPI-R2 board with MT7623 and the result can as well bring benefits into the other MediaTek PMICs such as MT6397 or SoCs.

The series sent across mfd, rtc, pm, dt-binding sub-system is for hoping to let people have a simple cross-reference to know the exact dependency and why those patches are being split in that way between each one.

Patch 1-3: Add dt-binding to the related devices newly or already
supported.
Patch 4-5: Extend driver with the functionality of MT6323 RTC device. Patch 6-9 and 12-13: Add a few of trivial fixups, cleanups and
improvements.
Patch 10-11: It's a preparation for Patch 14 adding a new driver. Patch 14: Add a new driver for a power-off driver.
Patch 15-16: Update MAINTAINERS with these new files being added.

Sean

Sean Wang (17):
dt-bindings: power: reset: mt6323: add bindings for MT6323 power
controller
dt-bindings: rtc: mt6397: add bindings for MediaTek PMIC based RTC
dt-bindings: mfd: mt6397: add a description for MT6323 RTC
dt-bindings: mfd: mt6397: add a description for MT6323 power
controller
mfd: mt6397: add MT6323 RTC support into MT6397 driver
mfd: mt6397: add support for MT6323 power controller into MT6397
driver
mfd: mt6397: reuse DEFINE_RES_* helpers
rtc: mt6397: add MT6323 support to RTC driver
rtc: mt6397: replace a poll with regmap_read_poll_timeout
rtc: mt6397: remove unnecessary irq_dispose_mapping
rtc: mt6397: convert to use device managed functions
rtc: mt6397: move the declaration into a globally visible header file
rtc: mt6397: cleanup header files to include
rtc: mt6397: update license converting to using SPDX identifiers
power: reset: mt6323: add a driver for MT6323 power controller
MAINTAINERS: update entry for ARM/Mediatek RTC DRIVER
MAINTAINERS: add an entry for MediaTek board level shutdown driver

 Documentation/devicetree/bindings/mfd/mt6397.txt   |  10 +-
 .../bindings/power/reset/mt6323-poweroff.txt       |  20 +++
 .../devicetree/bindings/rtc/rtc-mt6397.txt         |  29 ++++
 MAINTAINERS                                        |   9 ++
 drivers/mfd/mt6397-core.c                          |  40 ++++--
 drivers/power/reset/Kconfig                        |  10 ++
 drivers/power/reset/Makefile                       |   1 +
 drivers/power/reset/mt6323-poweroff.c              |  97 ++++++++++++++
 drivers/rtc/rtc-mt6397.c                           | 146 +++++----------------
 include/linux/mfd/mt6397/rtc.h                     |  71 ++++++++++
 10 files changed, 308 insertions(+), 125 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-mt6397.txt
 create mode 100644 drivers/power/reset/mt6323-poweroff.c
 create mode 100644 include/linux/mfd/mt6397/rtc.h
Signature · 1 line
2.7.4