Skip to content

Ethernet: Add and use ether_<type>_addr globals

Joe Perches b43-dev bridge linux-wireless lkml netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12ethernet: Add generic ether_<foo>_addr addressesinclude/linux/etherdevice.h net/ethernet/Makefile net/ethernet/ether_addrs.c+28 -50 replies
2/12treewide/net: Rename eth_stp_addr to ether_stp_addrdrivers/net/dsa/lan9303-core.c include/linux/etherdevice.h net/bridge/br_device.c+6 -54 replies
3/12net: mac80211: Use global ether_broadcast_addrnet/mac80211/iface.c net/mac80211/key.c net/mac80211/mesh_hwmp.c +1 more+17 -210 replies
4/12bridge: netfilter: Use the new global ether_<foo>_addr arraysnet/bridge/netfilter/ebt_stp.c+2 -42 replies
5/12net: atm: Use ether_broadcast_addrnet/atm/lec.c+5 -70 replies
6/12wireless: Convert simple uses of a static const Ethernet broadcast addressdrivers/net/wireless/admtek/adm8211.c drivers/net/wireless/ath/carl9170/mac.c drivers/net/wireless/broadcom/b43/main.c +5 more+9 -254 replies
7/12brcmfmac: Convert ALLFFMAC to ether_broadcast_addrdrivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c+4 -81 reply
8/12iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addrdrivers/net/wireless/intel/iwlegacy/3945-mac.c drivers/net/wireless/intel/iwlegacy/4965-mac.c drivers/net/wireless/intel/iwlegacy/common.c +1 more+2 -60 replies
9/12iwlwifi: Remove local iwl_bcast_addr and use ether_broadcast_addrdrivers/net/wireless/intel/iwlwifi/dvm/dev.h drivers/net/wireless/intel/iwlwifi/dvm/scan.c drivers/net/wireless/intel/iwlwifi/dvm/sta.c+2 -52 replies
10/12mvpp2: Use ether_broadcast_addr instead of a local arraydrivers/net/ethernet/marvell/mvpp2.c+1 -30 replies
11/12qlogic: Convert local bcast_addr to global ether_broadcast_addrdrivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c+5 -120 replies
12/12ethernet: Use ether_zero_addr instead of local staticsdrivers/net/ethernet/broadcom/b44.c drivers/net/ethernet/freescale/gianfar.c+3 -50 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchArend van Spriel
1/12
2/12
3/12
4/12
5/12
6/12
7/12A-b
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] Ethernet: Add and use ether_<type>_addr globals

There are many local static and non-static arrays that are used for Ethernet broadcast address output or comparison.

Centralize the array into a single separate file and remove the local arrays.

Joe Perches (12):
ethernet: Add generic ether_<foo>_addr addresses
treewide/net: Rename eth_stp_addr to ether_stp_addr
net: mac80211: Use global ether_broadcast_addr
bridge: netfilter: Use the new global ether_<foo>_addr arrays
net: atm: Use ether_broadcast_addr
wireless: Convert simple uses of a static const Ethernet broadcast address
brcmfmac: Convert ALLFFMAC to ether_broadcast_addr
iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addr
iwlwifi: Remove local iwl_bcast_addr and use ether_broadcast_addr
mvpp2: Use ether_broadcast_addr instead of a local array
qlogic: Convert local bcast_addr to global ether_broadcast_addr
ethernet: Use ether_zero_addr instead of local statics

 drivers/net/dsa/lan9303-core.c                        |  4 ++--
 drivers/net/ethernet/broadcom/b44.c                   |  5 ++---
 drivers/net/ethernet/freescale/gianfar.c              |  3 +--
 drivers/net/ethernet/marvell/mvpp2.c                  |  4 +---
 drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c    |  5 +----
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c        |  6 ++----
 .../net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c  |  6 ++----
 drivers/net/wireless/admtek/adm8211.c                 |  3 +--
 drivers/net/wireless/ath/carl9170/mac.c               |  4 +---
 drivers/net/wireless/broadcom/b43/main.c              |  3 +--
 .../net/wireless/broadcom/brcm80211/brcmfmac/common.c |  2 --
 .../net/wireless/broadcom/brcm80211/brcmfmac/common.h |  2 --
 .../wireless/broadcom/brcm80211/brcmfmac/flowring.c   |  8 ++++----
 drivers/net/wireless/intel/iwlegacy/3945-mac.c        |  2 +-
 drivers/net/wireless/intel/iwlegacy/4965-mac.c        |  2 +-
 drivers/net/wireless/intel/iwlegacy/common.c          |  3 ---
 drivers/net/wireless/intel/iwlegacy/common.h          |  1 -
 drivers/net/wireless/intel/iwlwifi/dvm/dev.h          |  1 -
 drivers/net/wireless/intel/iwlwifi/dvm/scan.c         |  2 +-
 drivers/net/wireless/intel/iwlwifi/dvm/sta.c          |  4 +---
 drivers/net/wireless/marvell/mwifiex/cfg80211.c       |  3 +--
 drivers/net/wireless/realtek/rtlwifi/core.c           |  5 ++---
 drivers/net/wireless/rndis_wlan.c                     |  6 +-----
 drivers/net/wireless/ti/wl1251/main.c                 |  5 +----
 drivers/net/wireless/ti/wlcore/main.c                 |  5 +----
 include/linux/etherdevice.h                           | 13 +++++++++----
 net/atm/lec.c                                         | 12 +++++-------
 net/bridge/br_device.c                                |  4 ++--
 net/bridge/netfilter/ebt_stp.c                        |  6 ++----
 net/ethernet/Makefile                                 |  2 +-
 net/ethernet/ether_addrs.c                            | 19 +++++++++++++++++++
 net/mac80211/iface.c                                  |  5 +----
 net/mac80211/key.c                                    |  6 ++----
 net/mac80211/mesh_hwmp.c                              | 19 ++++++++++---------
 net/mac80211/mesh_pathtbl.c                           |  8 ++++----
 35 files changed, 83 insertions(+), 105 deletions(-)
 create mode 100644 net/ethernet/ether_addrs.c
Signature · 1 line
2.15.0