Skip to content

spi: mpc8xxx: DM conversion

Mario Six u-boot 6 versions – New

Get series with b4
b4 am CAN1kZopki0d1jJDitXBv34NatLF89M7nSyt1QEz0-5YtrxGBHg@mail.gmail.com

Versions newest first · linked by author and title

  1. v2 Latest posting 5/50 of 18 patches 0 repliesNew
  2. v2 posting 4/50 of 18 patches 0 repliesSuperseded
  3. v2 posting 3/50 of 18 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/50 of 18 patches0 repliesSuperseded
v2 posting 1/518 patches0 repliesSuperseded
v119 patches0 repliesSuperseded

Patches in v2 posting 5/5 No applies recorded yet

None of the 18 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 00/18] spi: mpc8xxx: DM conversion

Hi Jagan, Heiko,

Quoted 73 lines · Jagan Teki

Hi Mario/Kim/Heiko,

Quoted 68 lines · Christophe LEROY

Hi Mario,

Quoted 64 lines · Mario Six

Hi Christophe,

Quoted 59 lines · Christophe LEROY

Hello Mario,

Quoted 54 lines · Mario Six

Hi Joakim,

Quoted 49 lines · Joakim Tjernlund
Quoted 47 lines · Jagan Teki
Quoted 44 lines · Mario Six

Hi Jagan,

Quoted 39 lines · Jagan Teki
Quoted 34 lines · Mario Six

This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
driver, cleans up the driver code, fixes a few minor problems.

Some TODOs are left over for later, such as proper SPI speed setting,
and support for SPI mode setting. These would be enhancements to the
original functionality, and can come later.

The legacy functionality is removed in this version, so old boards in
the tree might end up with broken SPI functionality.

Mario Six (18):
spi: mpc8xxx: Use short type names
spi: mpc8xxx: Fix comments
spi: mpc8xxx: Rename camel-case variables
spi: mpc8xxx: Fix space after cast
spi: mpc8xxx: Fix function names in strings
spi: mpc8xxx: Replace defines with enums
spi: mpc8xxx: Use IO accessors
spi: mpc8xxx: Simplify if
spi: mpc8xxx: Get rid of is_read
spi: mpc8xxx: Simplify logic a bit
spi: mpc8xxx: Reduce scope of loop variables
spi: mpc8xxx: Make code more readable
spi: mpc8xxx: Rename variable
spi: mpc8xxx: Document LEN setting better
spi: mpc8xxx: Re-order transfer setup
spi: mpc8xxx: Fix if check
spi: mpc8xxx: Use get_timer
spi: mpc8xxx: Convert to DM

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

Boards with
- configs/MPC8349EMDS_defconfig
- configs/ids8313_defconfig

Can you convert this boards to use DM_SPI, we have build issue[2]

Heiko, if you agree, I'd say we disable the SPI support for this board for now (and possibly permanently), since really supporting the SPI multiplexer would entail writing a DM driver for it, which would entail creating a SPI mux uclass, and similar inconveniences (and I think putting that much work in a board that old is at least dubious). As far as I can tell, this is the only board with the multiplexer mechanism.

I have two more larger conversion series in my queue, which will hopefully make it easier to convert the MPC83xx boards to DM (including SPI), but since I'm busy working on non-U-Boot-related things right now, I won't be able to finalize the first this week; hopefully next week.

Quoted 3 lines

[2] https://travis-ci.org/openedev/u-boot-amarula/jobs/412956049

Best regards,
Mario