Coverity fixes for EAL memory
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest9 patches 2 repliesIn review
- v2 posting 2/21 patch 0 repliesSuperseded
- v39 patches 18 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 posting 1/2 | 10 patches | 0 replies | Superseded | |
| v1 | 10 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
- Better comments for fd leak fixes
- Improve fix for double close fd
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | mem: use strlcpy instead of snprintflib/ | +3 | 0 replies | |
| 2/9 | mem: fix resource leaklib/ | +1 | 0 replies | |
| 3/9 | mem: fix potential double closelib/ | +4 | 1 reply | |
| 4/9 | mem: fix potential resource leaklib/ | +4 | 0 replies | |
| 5/9 | mem: fix potential resource leaklib/ | +4 | 0 replies | |
| 6/9 | mem: fix comparing pointer to valuelib/ | +1 | 0 replies | |
| 7/9 | mem: fix potential bad unmaplib/ | +2 | 0 replies | |
| 8/9 | mem: fix statement having no effectlib/ | +6 | 0 replies | |
| 9/9 | mem: fix possible use-after-freelib/ | +3 | 0 replies |
Reviews trailers per patch
8 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Bruce Richardson |
|---|---|
| 1/9 | A-b |
| 2/9 | A-b |
| 3/9 | A-b |
| 4/9 | A-b |
| 5/9 | |
| 6/9 | A-b |
| 7/9 | A-b |
| 8/9 | A-b |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/9] Coverity fixes for EAL memory
This patchset fixes a host of coverity issues in memory subsystem introduced with recent DPDK memory hotplug patchset.
Coverity issues fixed:
- 272601 - leaking fd
- 272560 - double close fd
- 272568 - leaking fd
- 272570 - leaking fd
- 272589 - dereference before null check
- 272602 - freeing wrong pointer
- 272608 - expression does nothing
- 272584 - use after free
Coverity issues not fixed:
- 272577 - negative return not handled
- 272578 - negative return not handled
- Proper usage of API guarantees no negative returns
Additionally, also replace all instances of snprintf with strlcpy.
v4:
- Better comments for fd leak fixes
- Improve fix for double close fd
v3:
- Drop fixes for 272577 and 272578 and mark them as false positives
v2:
- Rebase on top of latest master
Anatoly Burakov (9):
mem: use strlcpy instead of snprintf
mem: fix resource leak
mem: fix potential double close
mem: fix potential resource leak
mem: fix potential resource leak
mem: fix comparing pointer to value
mem: fix potential bad unmap
mem: fix statement having no effect
mem: fix possible use-after-free
lib/librte_eal/common/eal_common_memalloc.c | 5 +++-- lib/librte_eal/common/eal_common_memory.c | 6 +++--- lib/librte_eal/linuxapp/eal/eal_memalloc.c | 33 ++++++++++++++++++----------- lib/librte_eal/linuxapp/eal/eal_memory.c | 1 + 4 files changed, 28 insertions(+), 17 deletions(-)
Signature · 1 line
2.7.4