Fix port memory offsets for IDIO series drivers
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | gpio: pci-idio-16: Fix port memory offset for get_multiple callbackdrivers/ | +4 | 1 reply | |
| 2/2 | gpio: pcie-idio-24: Fix port memory offset for get_multiple/set_multiple callbacksdrivers/ | +10 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] Fix port memory offsets for IDIO series drivers
The GPIO PCI-IDIO-16 and PCIE-IDIO-24 drivers utilize the ioread8 and iowrite8 functions to interact with their devices' respective I/O registers. To simplify the get_multiple/set_multiple callbacks, a local array 'ports' is used to hold the memory address offsets of the respective device I/O registers.
Currently the get_multiple callback in the GPIO PCI-IDIO-16 driver, and the get_multiple/set_multiple callbacks in the GPIO PCIE-IDIO-24 driver, incorrectly pass the memory address of the local 'ports' array elements to the respective ioread8/iowrite8 functions when they should instead pass the necessary device I/O register memory offset. This patch fixes this error by supplying the correct intended memory addresses to these functions.
William Breathitt Gray (2):
gpio: pci-idio-16: Fix port memory offset for get_multiple callback
gpio: pcie-idio-24: Fix port memory offset for
get_multiple/set_multiple callbacks
drivers/gpio/gpio-pci-idio-16.c | 8 ++++---- drivers/gpio/gpio-pcie-idio-24.c | 20 ++++++++++---------- 2 files changed, 14 insertions(+), 14 deletions(-)
Signature · 1 line
2.16.2