Skip to content

arm/arm64: mediatek: Fix mmsys device probing

Matthias Brugger dri-devel linux-arm-kernel linux-clk linux-mediatek lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest9 of 10 patches 2 repliesIn review

Changes in v2 from the cover letter

- add binding documentation
- ddp: use regmap_update_bits
- ddp: ignore EPROBE_DEFER on clock probing
- mfd: delete mmsys_private
- add Reviewed-by and Acked-by tags

9 of 10 patches are in this archive. The cover letter announces 10.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10dt-bindings: mediatek: mmsys: Add support for mfdDocumentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt+28 -30 replies
2/10drm/mediatek: Use regmap for register accessdrivers/gpu/drm/mediatek/mtk_drm_crtc.c drivers/gpu/drm/mediatek/mtk_drm_ddp.c drivers/gpu/drm/mediatek/mtk_drm_ddp.h +2 more+24 -370 replies
3/10mfd: mtk-mmsys: Add mmsys driverdrivers/mfd/Kconfig drivers/mfd/Makefile drivers/mfd/mtk-mmsys.c+90 -00 replies
5/10clk: mediatek: mt2701-mm: switch to mfd devicedrivers/clk/mediatek/clk-mt2701-mm.c+3 -70 replies
6/10mfd: mtk-mmsys: Add mt8173 nodesdrivers/mfd/mtk-mmsys.c+14 -00 replies
7/10drm/mediatek: Add mfd support for mt8173drivers/gpu/drm/mediatek/mtk_drm_drv.c+7 -210 replies
8/10clk: mediatek: mt8173-mm: switch to mfd devicedrivers/clk/mediatek/clk-mt8173.c+15 -20 replies
9/10drm: mediatek: Omit warning on probe defersdrivers/gpu/drm/mediatek/mtk_drm_ddp.c+2 -10 replies
10/10MAINTAINERS: update Mediatek Soc entryMAINTAINERS+2 -00 replies

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchPhilipp ZabelStephen Boyd
1/10
2/10R-b
3/10
5/10A-b
6/10R-b
7/10R-b
8/10A-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [v2 00/10] arm/arm64: mediatek: Fix mmsys device probing

Changes since v1:
- add binding documentation
- ddp: use regmap_update_bits
- ddp: ignore EPROBE_DEFER on clock probing
- mfd: delete mmsys_private
- add Reviewed-by and Acked-by tags

---

MMSYS in Mediatek SoCs has some registers to control clock gates (which is used in the clk driver) and some registers to set the routing and enable the differnet blocks of the display subsystem.

Up to now both drivers, clock and drm are probed with the same device tree compatible. But only the first driver get probed, which in effect breaks graphics on mt8173 and mt2701.

This patch set introduces a new mfd device, which binds against the mmsys compatible and takes care of probing the needed devices. It was tested on the bananapi-r2 and the Acer R13 Chromebook.

Matthias Brugger (10):
dt-bindings: mediatek: mmsys: Add support for mfd drm/mediatek: Use regmap for register access
mfd: mtk-mmsys: Add mmsys driver drm/mediatek: mt2701: switch to mfd probing.
clk: mediatek: mt2701-mm: switch to mfd device
mfd: mtk-mmsys: Add mt8173 nodes drm/mediatek: Add mfd support for mt8173
clk: mediatek: mt8173-mm: switch to mfd device
drm: mediatek: Omit warning on probe defers
MAINTAINERS: update Mediatek Soc entry

 .../bindings/arm/mediatek/mediatek,mmsys.txt       |  2 -
 .../bindings/display/mediatek/mediatek,disp.txt    |  2 +-
 .../devicetree/bindings/mfd/mediatek,mmsys.txt     | 27 +++++++
 MAINTAINERS                                        |  2 +
 drivers/clk/mediatek/clk-mt2701-mm.c               | 10 +--
 drivers/clk/mediatek/clk-mt8173.c                  | 17 +++-
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c            |  4 +-
 drivers/gpu/drm/mediatek/mtk_drm_ddp.c             | 41 ++++------
 drivers/gpu/drm/mediatek/mtk_drm_ddp.h             |  4 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c             | 33 ++++----
 drivers/gpu/drm/mediatek/mtk_drm_drv.h             |  2 +-
 drivers/mfd/Kconfig                                |  9 +++
 drivers/mfd/Makefile                               |  2 +
 drivers/mfd/mtk-mmsys.c                            | 93 ++++++++++++++++++++++
 14 files changed, 189 insertions(+), 59 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
 create mode 100644 drivers/mfd/mtk-mmsys.c
Signature · 1 line
2.16.3