Skip to content

Simplify counting of extent buffer pages

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: simplify counting number of eb pagesfs/btrfs/extent_io.h+1 -24 replies
2/3btrfs: pass only eb to num_extent_pagesfs/btrfs/extent_io.c fs/btrfs/extent_io.h+17 -171 reply
3/3btrfs: switch types to int when counting eb pagesfs/btrfs/extent_io.c fs/btrfs/extent_io.h+23 -231 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/3
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Simplify counting of extent buffer pages

Some low-hanging cleanup fruit. The argument bloat-o-meter shows some improvements:

extent_io.c:cache_state_if_flags.part.27 -8 (8 -> 0)
extent_io.c:cache_state.part.28 -8 (8 -> 0)
extent_io.c:check_buffer_tree_ref.part.31 -24 (24 -> 0)
extent_io.c:mark_extent_buffer_accessed -8 (40 -> 32)
extent_io.c:alloc_extent_state_atomic.part.35 -8 (8 -> 0)
extent_io.c:flush_write_bio.isra.40 -16 (16 -> 0)

extent_io.c:set_page_extent_mapped.part.49     -8 (8 -> 0)
extent_io.c:extent_buffer_under_io.part.50     -8 (8 -> 0)
extent_io.c:__unlock_for_delalloc.isra.38      -8 (8 -> 0)
extent_io.c:merge_state.part.45               -48 (48 -> 0)
extent_io.c:repair_eb_io_failure               -8 (72 -> 64)
extent_io.c:set_extent_buffer_dirty            -8 (40 -> 32)
extent_io.c:__alloc_dummy_extent_buffer        +8 (32 -> 40)

extent_io.c:write_one_eb +16 (152 -> 168)

David Sterba (3):
btrfs: simplify counting number of eb pages
btrfs: pass only eb to num_extent_pages
btrfs: switch types to int when counting eb pages

 fs/btrfs/extent_io.c | 68 ++++++++++++++++++++++++++--------------------------
 fs/btrfs/extent_io.h |  5 ++--
 2 files changed, 36 insertions(+), 37 deletions(-)
Signature · 1 line
2.16.2