sctp: refactor MTU handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest13 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | sctp: remove old and unused SCTP_MIN_PMTUinclude/ | +2 | 0 replies | |
| 2/13 | sctp: move transport pathmtu calc away of sctp_assoc_add_peernet/ net/ | +7 | 0 replies | |
| 3/13 | sctp: remove an if() that is always truenet/ | +2 | 3 replies | |
| 4/13 | sctp: introduce sctp_assoc_set_pmtuinclude/ net/ net/ | +15 | 0 replies | |
| 5/13 | sctp: introduce sctp_mtu_payloadinclude/ net/ net/ | +31 | 0 replies | |
| 6/13 | sctp: introduce sctp_assoc_update_frag_pointinclude/ include/ net/ +2 more | +20 | 0 replies | |
| 7/13 | sctp: remove sctp_assoc_pending_pmtuinclude/ net/ | +4 | 0 replies | |
| 8/13 | sctp: introduce sctp_dst_mtuinclude/ net/ net/ | +12 | 0 replies | |
| 9/13 | sctp: remove sctp_transport_pmtu_checkinclude/ net/ | +0 | 0 replies | |
| 10/13 | sctp: re-use sctp_transport_pmtu in sctp_transport_routenet/ net/ | +19 | 0 replies | |
| 11/13 | sctp: honor PMTU_DISABLED when handling icmpnet/ | +5 | 0 replies | |
| 12/13 | sctp: consider idata chunks when setting SCTP_MAXSEGnet/ | +6 | 0 replies | |
| 13/13 | sctp: allow unsetting sockopt MAXSEGnet/ | +0 | 0 replies |
Reviews trailers per patch
None of the 13 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Xin Long |
|---|---|
| Series | R-b |
| 1/13 | |
| 2/13 | |
| 3/13 | |
| 4/13 | |
| 5/13 | |
| 6/13 | |
| 7/13 | |
| 8/13 | |
| 9/13 | |
| 10/13 | |
| 11/13 | |
| 12/13 | |
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 00/13] sctp: refactor MTU handling
Currently MTU handling is spread over SCTP stack. There are multiple places doing same/similar calculations and updating them is error prone as one spot can easily be left out.
This patchset converges it into a more concise and consistent code. In general, it moves MTU handling from functions with bigger objectives, such as sctp_assoc_add_peer(), to specific functions.
It's also a preparation for the next patchset, which removes the duplication between sctp_make_op_error_space and sctp_make_op_error_fixed and relies on sctp_mtu_payload introduced here.
More details on each patch.
Marcelo Ricardo Leitner (13):
sctp: remove old and unused SCTP_MIN_PMTU
sctp: move transport pathmtu calc away of sctp_assoc_add_peer
sctp: remove an if() that is always true
sctp: introduce sctp_assoc_set_pmtu
sctp: introduce sctp_mtu_payload
sctp: introduce sctp_assoc_update_frag_point
sctp: remove sctp_assoc_pending_pmtu
sctp: introduce sctp_dst_mtu
sctp: remove sctp_transport_pmtu_check
sctp: re-use sctp_transport_pmtu in sctp_transport_route
sctp: honor PMTU_DISABLED when handling icmp
sctp: consider idata chunks when setting SCTP_MAXSEG
sctp: allow unsetting sockopt MAXSEG
include/net/sctp/constants.h | 5 ++-- include/net/sctp/sctp.h | 52 ++++++++++++++------------------------ include/net/sctp/structs.h | 2 ++ net/sctp/associola.c | 60 +++++++++++++++++++++++--------------------- net/sctp/chunk.c | 12 +-------- net/sctp/output.c | 28 ++++++++------------- net/sctp/socket.c | 43 ++++++++++++++----------------- net/sctp/transport.c | 37 ++++++++++++++------------- 8 files changed, 105 insertions(+), 134 deletions(-)
--
2.14.3