Skip to content

bridge: FDB: Notify about removal of non-user-added entries

Petr Machata bridge netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 6 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Instead of introducing a new variant of fdb_delete(), add a new parameter to the existing function.
- Name the parameter swdev_notify, not notify.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2switchdev: Add fdb.added_by_user to switchdev notificationsdrivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c drivers/net/ethernet/rocker/rocker_main.c include/net/switchdev.h +2 more+18 -41 reply
2/2net: bridge: Notify about !added_by_user FDB entriesnet/bridge/br.c net/bridge/br_fdb.c net/bridge/br_private.h +1 more+33 -263 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNikolay AleksandrovIvan Vecera
1/2R-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next mlxsw v2 0/2] bridge: FDB: Notify about removal of non-user-added entries

Device drivers may generally need to keep in sync with bridge's FDB. In particular, for its offload of tc mirror action where the mirrored-to device is a gretap device, mlxsw needs to listen to a number of events, FDB events among the others. SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE would be a natural notification in that case.

However, for removal of FDB entries added due to device activity (as opposed to explicit addition through "bridge fdb add" or similar), there are no notifications.

Thus in patch #1, add the "added_by_user" field to switchdev notifications sent for FDB activity. Adapt drivers to ignore activity on non-user-added entries, to maintain the current behavior. Specifically in case of mlxsw, allow mlxsw_sp_span_respin() call for any and all FDB updates.

In patch #2, change the bridge driver to actually emit notifications for these FDB entries. Take care not to send notification for bridge updates that itself originate in SWITCHDEV_FDB_*_TO_BRIDGE events.

Changes from v1 to v2:
- Instead of introducing a new variant of fdb_delete(), add a new parameter to the existing function.
- Name the parameter swdev_notify, not notify.

Petr Machata (2):
switchdev: Add fdb.added_by_user to switchdev notifications
net: bridge: Notify about !added_by_user FDB entries

 .../ethernet/mellanox/mlxsw/spectrum_switchdev.c   |  4 ++
 drivers/net/ethernet/rocker/rocker_main.c          |  2 +
 include/net/switchdev.h                            |  1 +
 net/bridge/br.c                                    |  4 +-
 net/bridge/br_fdb.c                                | 47 ++++++++++++----------
 net/bridge/br_private.h                            |  6 ++-
 net/bridge/br_switchdev.c                          | 12 ++++--
 net/dsa/slave.c                                    |  5 ++-
 8 files changed, 51 insertions(+), 30 deletions(-)
Signature · 1 line
2.4.11