Skip to content

net: stmmac: Be less dependent on Synopsys ID

Jose Abreu netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net: stmmac: Let descriptor code set skbuff addressdrivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c drivers/net/ethernet/stmicro/stmmac/enh_desc.c drivers/net/ethernet/stmicro/stmmac/hwif.h +2 more+29 -192 replies
2/10net: stmmac: Let descriptor code clear the descriptordrivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c drivers/net/ethernet/stmicro/stmmac/enh_desc.c drivers/net/ethernet/stmicro/stmmac/hwif.h +2 more+26 -80 replies
3/10net: stmmac: Uniformize the use of dma_{rx/tx}_mode callbacksdrivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c +2 more+86 -860 replies
4/10net: stmmac: Remove uneeded checks for GMAC versiondrivers/net/ethernet/stmicro/stmmac/stmmac_main.c+5 -110 replies
5/10net: stmmac: Move PTP and MMC base address calculation to hwif.cdrivers/net/ethernet/stmicro/stmmac/hwif.c drivers/net/ethernet/stmicro/stmmac/hwif.h drivers/net/ethernet/stmicro/stmmac/stmmac_main.c+39 -80 replies
6/10net: stmmac: Uniformize the use of dma_init_* callbacksdrivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c +2 more+65 -540 replies
7/10net: stmmac: Remove uneeded check for GMAC version in stmmac_xmitdrivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h drivers/net/ethernet/stmicro/stmmac/stmmac_main.c+2 -60 replies
8/10net: stmmac: Do not initialize the RX Descriptor twicedrivers/net/ethernet/stmicro/stmmac/stmmac_main.c+1 -41 reply
9/10net: stmmac: Let descriptor code get skbuff addressdrivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c drivers/net/ethernet/stmicro/stmmac/enh_desc.c drivers/net/ethernet/stmicro/stmmac/hwif.h +2 more+23 -50 replies
10/10net: stmmac: Remove if condition by taking advantage of hwif return codedrivers/net/ethernet/stmicro/stmmac/stmmac_main.c+11 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/10] net: stmmac: Be less dependent on Synopsys ID

David,

This series was based on top of [1]. Please see my reply on [1] and let me know if I need to rebase against -next without this dependecy.

All,

This targets to uniformize the handling of the different GMAC versions in stmmac_main.c file.

Currently there are some if/else conditions in the main source file which calls different callbacks depending on the ID of GMAC.

With the introducion of a generic HW interface handling which automatically selects the GMAC callbacks to be used, it is now unpleasant to see if conditions in the main code because this should be completely agnostic of the GMAC version.

This series removes most of these conditions. There are some if conditions that remain untouched but the callbacks handling are now uniformized.

Tested in GMAC5, hope I didn't break any previous versions.

[1] https://patchwork.ozlabs.org/patch/908618/

Cc David S. Miller <[email protected]>
Cc Joao Pinto <[email protected]>
Cc Vitor Soares <[email protected]>
Cc Giuseppe Cavallaro <[email protected]>
Cc Alexandre Torgue <[email protected]>

Jose Abreu (10):
net: stmmac: Let descriptor code set skbuff address
net: stmmac: Let descriptor code clear the descriptor
net: stmmac: Uniformize the use of dma_{rx/tx}_mode callbacks
net: stmmac: Remove uneeded checks for GMAC version
net: stmmac: Move PTP and MMC base address calculation to hwif.c
net: stmmac: Uniformize the use of dma_init_* callbacks
net: stmmac: Remove uneeded check for GMAC version in stmmac_xmit
net: stmmac: Do not initialize the RX Descriptor twice
net: stmmac: Let descriptor code get skbuff address
net: stmmac: Remove if condition by taking advantage of hwif return
code

 drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c  |   57 ++++---
 .../net/ethernet/stmicro/stmmac/dwmac1000_dma.c    |   92 ++++++----
 drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c |   35 +++--
 drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c |   22 +++
 drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c   |    3 +-
 drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h   |    1 -
 drivers/net/ethernet/stmicro/stmmac/enh_desc.c     |   18 ++
 drivers/net/ethernet/stmicro/stmmac/hwif.c         |   34 ++++
 drivers/net/ethernet/stmicro/stmmac/hwif.h         |   25 ++-
 drivers/net/ethernet/stmicro/stmmac/norm_desc.c    |   18 ++
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  |  193 +++++++-------------
 11 files changed, 286 insertions(+), 212 deletions(-)