Skip to content

treewide: Add and use dev_fmt similar to pr_fmt

Joe Perches linux-rdma lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6x86/early-quirks: Rename duplicate define of dev_errarch/x86/kernel/early-quirks.c+4 -42 replies
2/6device: Add #define dev_fmt similar to #define pr_fmtdrivers/base/core.c include/linux/device.h+64 -5111 replies
3/6ipmi: msghandler: Add and use pr_fmt and dev_fmt, remove PFXdrivers/char/ipmi/ipmi_msghandler.c+25 -280 replies
4/6ipmi: Use more common logging stylesdrivers/char/ipmi/ipmi_poweroff.c drivers/char/ipmi/ipmi_si_hardcode.c drivers/char/ipmi/ipmi_si_hotmod.c +5 more+132 -1400 replies
5/6ipmi: Convert printk(KERN_<level> to pr_<level>(drivers/char/ipmi/ipmi_bt_sm.c drivers/char/ipmi/ipmi_devintf.c drivers/char/ipmi/ipmi_kcs_sm.c +1 more+48 -570 replies
6/6infiniband: qplib_fp: Use dev_fmtdrivers/infiniband/hw/bnxt_re/qplib_fp.c+57 -682 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCorey MinyardThomas GleixnerDoug LedfordSelvin Xavier
SeriesA-b
1/6R-b
2/6
3/6
4/6
5/6
6/6A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] treewide: Add and use dev_fmt similar to pr_fmt

The pr_fmt mechanism exists for pr_<level> logging message prefixing, but no similar capability exists for dev_<level> message prefixing.

Many uses of dev_<level> have an embedded prefix for logging output.

So add a similar dev_fmt macro that can automatically prefix the dev_<level> logging output.

Rename the existing dev_<level> functions to _dev_<level> and add new macros that call _dev_<level> with the desired prefix if defined.

The new default #define for dev_fmt is blank.

Convert ipmi and infiniband to use this mechanism.

Miscellanea:

o x86/early-quirks uses an internal macro for #define dev_err which conflicts with the existing dev_err macro, so rename it.

Joe Perches (6):
x86/early-quirks: Rename duplicate define of dev_err
device: Add #define dev_fmt similar to #define pr_fmt
ipmi: msghandler: Add and use pr_fmt and dev_fmt, remove PFX
ipmi: Use more common logging styles
ipmi: Convert printk(KERN_<level> to pr_<level>(
infiniband: qplib_fp: Use dev_fmt

 arch/x86/kernel/early-quirks.c           |   8 +-
 drivers/base/core.c                      |  12 +--
 drivers/char/ipmi/ipmi_bt_sm.c           |  64 ++++++++--------
 drivers/char/ipmi/ipmi_devintf.c         |  11 ++-
 drivers/char/ipmi/ipmi_kcs_sm.c          |   4 +-
 drivers/char/ipmi/ipmi_msghandler.c      |  53 +++++++------
 drivers/char/ipmi/ipmi_poweroff.c        |  67 ++++++++---------
 drivers/char/ipmi/ipmi_si_hardcode.c     |   9 ++-
 drivers/char/ipmi/ipmi_si_hotmod.c       |  17 +++--
 drivers/char/ipmi/ipmi_si_intf.c         |  22 +++---
 drivers/char/ipmi/ipmi_si_pci.c          |  12 +--
 drivers/char/ipmi/ipmi_si_platform.c     |  20 ++---
 drivers/char/ipmi/ipmi_smic_sm.c         |  26 +++----
 drivers/char/ipmi/ipmi_ssif.c            |  73 +++++++++---------
 drivers/char/ipmi/ipmi_watchdog.c        |  52 +++++++------
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 125 ++++++++++++++-----------------
 include/linux/device.h                   | 103 ++++++++++++++-----------
 17 files changed, 330 insertions(+), 348 deletions(-)
Signature · 1 line
2.15.0