Skip to content

media: staging: atomisp:

Christophe JAILLET kernel-janitors linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3media: staging: atomisp: Return an error code in case of error in 'lm3554_probe()'drivers/staging/media/atomisp/i2c/atomisp-lm3554.c+4 -60 replies
2/3media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'drivers/staging/media/atomisp/i2c/atomisp-lm3554.c+2 -32 replies
3/3media: staging: atomisp: Fix usage of 'media_entity_cleanup()'drivers/staging/media/atomisp/i2c/atomisp-lm3554.c+3 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] media: staging: atomisp:

These 3 patches fixes (at least I hope) some issues found in or around 'lm3554_probe()'.

Please review them carefully. I've only compile tested the changes and I propose them because they sound logical to me.

The first one, return an error code instead of 0 if the call to an initialisation function fails.
The 2nd one reorders own some label are reached in order to have a logical flow (first error goes to last label, last error goes to first label) The 3rd one fix the use 'media_entity_cleanup()'. If this one is correct, some other drivers will need to be fixed the same way.

Christophe JAILLET (3):
media: staging: atomisp: Return an error code in case

    of error in 'lm3554_probe()'
  media: staging: atomisp: Fix an error handling path in
    'lm3554_probe()'

media: staging: atomisp: Fix usage of 'media_entity_cleanup()'

 .../media/atomisp/i2c/atomisp-lm3554.c        | 20 +++++++++----------
 1 file changed, 9 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.0