Skip to content

sctp: refactor sctp_outq_flush

Marcelo Ricardo Leitner linux-sctp netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyIn review
  2. v28 patches 1 replySuperseded
  3. v18 patches 1 replySuperseded

Changes in v3 from the cover letter

- fixed panic if building with just up to patch 3 applied

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8sctp: add sctp_packet_singletonnet/sctp/outqueue.c+15 -70 replies
2/8sctp: factor out sctp_outq_select_transportnet/sctp/outqueue.c+90 -970 replies
3/8sctp: move the flush of ctrl chunks into its own functionnet/sctp/outqueue.c+56 -360 replies
4/8sctp: move outq data rtx code out of sctp_outq_flushnet/sctp/outqueue.c+58 -430 replies
5/8sctp: move flushing of data chunks out of sctp_outq_flushnet/sctp/outqueue.c+75 -740 replies
6/8sctp: move transport flush code out of sctp_outq_flushnet/sctp/outqueue.c+26 -300 replies
7/8sctp: make use of gfp on retransmissionsnet/sctp/outqueue.c+9 -80 replies
8/8sctp: rework switch cases in sctp_outq_flush_datanet/sctp/outqueue.c+93 -980 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/8] sctp: refactor sctp_outq_flush

Currently sctp_outq_flush does many different things and arguably unrelated, such as doing transport selection and outq dequeueing.

This patchset refactors it into smaller and more dedicated functions. The end behavior should be the same.

The next patchset will rework the function parameters.

Changes since v1:
- fix build issues on patches 3 and 4, and updated 5 and 8 because of it.

Changes since v2:
- fixed panic if building with just up to patch 3 applied

Marcelo Ricardo Leitner (8):
sctp: add sctp_packet_singleton
sctp: factor out sctp_outq_select_transport
sctp: move the flush of ctrl chunks into its own function
sctp: move outq data rtx code out of sctp_outq_flush
sctp: move flushing of data chunks out of sctp_outq_flush
sctp: move transport flush code out of sctp_outq_flush
sctp: make use of gfp on retransmissions
sctp: rework switch cases in sctp_outq_flush_data

 net/sctp/outqueue.c | 593 +++++++++++++++++++++++++++-------------------------
 1 file changed, 311 insertions(+), 282 deletions(-)

--
2.14.3