Do not use command in profile
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest1 patch 0 repliesNew
- v31 patch 0 repliesSuperseded
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | base-files: profile: Avoid using "command" to determine if programs existmeta/ | +10 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCHv4 0/1] Do not use command in profile
Since we apparently cannot rely on the command utility to always exist, it is better to avoid using it in the profile script. Rather than using command to detect if tty and resize exist (which obviously will not work if command itself does not exist), just call them directly while piping any output for stderr to /dev/null. This should actually be a little bit more efficient in the case that they do exist, and the same in the case that they do not exist.
I leave to you to decide whether you want to revert commit e41c90b852 that enabled the command utility in busybox or not.
PATCHv2: Correct a typo in the commit message.
PATCHv3: Run resize twice, once to determine if it exists, and once to actually do the resize.
PATCHv4: Correct the same typo in the commit message once more...
//Peter
The following changes since commit 13cc30cd7de4841990b600e83e1249c81a5171dd:
local.conf.sample.extended: Drop obsolete rpc and libnsl (2018-05-15 11:07:50 +0100)
are available in the git repository at:
git://push.yoctoproject.org/poky-contrib pkj/profile_without_command
Peter Kjellerstedt (1):
base-files: profile: Avoid using "command" to determine if programs
exist
meta/recipes-core/base-files/base-files/profile | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
Signature · 1 line
2.12.0