Skip to content

mtd: rawnand: add NVIDIA Tegra NAND flash support

Stefan Agner linux-devicetree linux-mtd linux-tegra lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest6 patches 4 repliesIn review
  2. v76 patches 2 repliesSuperseded
  3. v66 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v56 patches4 repliesSuperseded
v46 patches16 repliesSuperseded
v36 patches34 repliesSuperseded
v26 patches19 repliesSuperseded
v15 patches33 repliesSuperseded

Changes in v8 from the cover letter

- Replace nand_release() with mtd_device_unregister() + nand_cleanup()

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mtd: rawnand: add Reed-Solomon error correction algorithmDocumentation/devicetree/bindings/mtd/nand.txt drivers/mtd/nand/raw/nand_base.c include/linux/mtd/rawnand.h+3 -10 replies
2/6mtd: rawnand: add an option to specify NAND chip as a boot deviceDocumentation/devicetree/bindings/mtd/nand.txt drivers/mtd/nand/raw/nand_base.c include/linux/mtd/rawnand.h+13 -01 reply
3/6mtd: rawnand: tegra: add devicetree bindingDocumentation/devicetree/bindings/mtd/nvidia-tegra20-nand.txt+64 -00 replies
4/6mtd: rawnand: add NVIDIA Tegra NAND Flash controller driverMAINTAINERS drivers/mtd/nand/raw/Kconfig drivers/mtd/nand/raw/Makefile +1 more+1248 -00 replies
5/6ARM: dts: tegra: add Tegra20 NAND flash controller nodearch/arm/boot/dts/tegra20.dtsi+15 -00 replies
6/6ARM: dts: tegra: enable NAND flash on Colibri T20arch/arm/boot/dts/tegra20-colibri-512.dtsi+16 -00 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchBoris BrezillonRob HerringDmitry Osipenko
1/6R-b A-b
2/6R-b A-b
3/6R-b R-b
4/6R-b R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/6] mtd: rawnand: add NVIDIA Tegra NAND flash support

Eigth and hopefully final revision gets rid of nand_release() as suggested by Boris.

--
Stefan

Changes since v1:
- Split controller and NAND chip structure
- Add BCH support
- Allow to select algorithm and strength using device tree
- Improve HW ECC error reporting and use DEC_STATUS_BUF only
- Use SPDX license identifier
- Use per algorithm mtd_ooblayout_ops
- Use setup_data_interface callback for NAND timing configuration

Changes since v2:
- Set clock rate using assigned-clocks
- Use BIT() macro
- Fix and improve timing calculation
- Improve ECC error handling
- Store OOB layout for tag area in Tegra chip structure
- Update/fix bindings
- Use more specific variable names (replace "value")
- Introduce nand-is-boot-medium
- Choose sensible ECC strenght automatically
- Use wait_for_completion_timeout
- Print register dump on completion timeout
- Unify tegra_nand_(read|write)_page in tegra_nand_page_xfer

Changes since v3:
- Implement tegra_nand_(read|write)_raw using DMA
- Implement tegra_nand_(read|write)_oob using DMA
- Name registers according to Tegra 2 Technical Reference Manual (v02p)
- Use wait_for_completion_io_timeout to account for IO
- Get chip select id from device tree reg property
- Clear interrupts and reinit wait queues in case command/DMA times out
- Set default MTD name after nand_set_flash_node
- Move MODULE_DEVICE_TABLE after declaration of tegra_nand_of_match
- Make (rs|bch)_strength static

Changes since v4:
- Pass OOB area to nand_check_erased_ecc_chunk
- Pass algorithm specific bits_per_step to tegra_nand_get_strength
- Store ECC layout in chip structure
- Fix pointer assignment (use NULL)
- Removed obsolete header delay.h
- Fixed newlines
- Use non-_io variant of wait_for_completion_timeout

Changes since v5:
- Drop extra OOB bytes support

Changes since v6:
- checkpatch.pl fixes

Changes since v7:
- Replace nand_release() with mtd_device_unregister() + nand_cleanup()

Lucas Stach (1):
ARM: dts: tegra: add Tegra20 NAND flash controller node

Stefan Agner (5):
mtd: rawnand: add Reed-Solomon error correction algorithm
mtd: rawnand: add an option to specify NAND chip as a boot device
mtd: rawnand: tegra: add devicetree binding
mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver
ARM: dts: tegra: enable NAND flash on Colibri T20

 .../devicetree/bindings/mtd/nand.txt          |    6 +-
 .../bindings/mtd/nvidia-tegra20-nand.txt      |   64 +
 MAINTAINERS                                   |    7 +
 arch/arm/boot/dts/tegra20-colibri-512.dtsi    |   16 +
 arch/arm/boot/dts/tegra20.dtsi                |   15 +
 drivers/mtd/nand/raw/Kconfig                  |   10 +
 drivers/mtd/nand/raw/Makefile                 |    1 +
 drivers/mtd/nand/raw/nand_base.c              |    4 +
 drivers/mtd/nand/raw/tegra_nand.c             | 1230 +++++++++++++++++
 include/linux/mtd/rawnand.h                   |    7 +
 10 files changed, 1359 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/mtd/nvidia-tegra20-nand.txt
 create mode 100644 drivers/mtd/nand/raw/tegra_nand.c
Signature · 1 line
2.17.1