PCI: imx: Initial imx7d suspend/resume support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v1 posting 2/21 patch 5 repliesApplied
- v4 Latest6 patches 7 repliesIn review
- v32 patches 12 repliesApplied
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 3 patches | 12 replies | Applied | |
| v1 posting 1/2 | 2 patches | 8 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"arch/ | +8 | 0 replies | |
| 2/6 | PCI: imx: Initial imx7d pm supportdrivers/ | +92 | 0 replies | |
| 3/6 | reset: imx7: Add PCIE_CTRL_APPS_TURNOFFdrivers/ include/ | +4 | 1 reply | |
| 4/6 | dt-bindings: imx6q-pcie: Add turnoff reset for imx7dDocumentation/ | +1 | 1 reply | |
| 5/6 | ARM: dts: imx7d: Add turnoff resetarch/ | +3 | 1 reply | |
| 6/6 | PCI: imx: Add PME_Turn_Off supportdrivers/ | +15 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Lucas Stach | Rob Herring | Shawn Guo |
|---|---|---|---|
| 1/6 | A-b | ||
| 2/6 | R-b | ||
| 3/6 | A-b | ||
| 4/6 | R-b | ||
| 5/6 | A-b | ||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support
On imx7d the pcie-phy power domain is turned off in suspend and this can make the system hang on resume when attempting any read from PCI.
Fix this by adding PM_SLEEP support to the imx6 pci driver. This is currently only enabled for imx7d but the suspend/resume sequence also applies to other socs.
V3 of this series was reviewed by Lucas but stalled because the merge window opened.
There was also some confusion about how to deal with the dependence on commit 26fce0557fa6 ("reset: imx7: Fix always writing bits as 0"). To
clarify: both patch 2 and 26fce0557fa6 are required to fix imx7d suspend but merging one without the other shouldn't cause other issues.
V4 adds 4 more patches with PME_Turn_Off support on top, using a new reset bit. I generally try to keep series short but in this case some planning might be needed to get patches into 4.20.
Since the new reset is treated as optional with old DTB there should be again no problem if reset and pci are merged out of order.
Shawn/Philipp/Lorenzo: Would it make sense to merge this series through a single specific tree, such as the one for imx?
Link to v3: https://lkml.org/lkml/2018/7/24/713
Leonard Crestez (6):
Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"
PCI: imx: Initial imx7d pm support
reset: imx7: Add PCIE_CTRL_APPS_TURNOFF
dt-bindings: imx6q-pcie: Add turnoff reset for imx7d
ARM: dts: imx7d: Add turnoff reset
PCI: imx: Add PME_Turn_Off support
.../bindings/pci/fsl,imx6q-pcie.txt | 1 + arch/arm/boot/dts/imx7d.dtsi | 17 ++- drivers/pci/controller/dwc/pci-imx6.c | 112 +++++++++++++++++- drivers/reset/reset-imx7.c | 1 + include/dt-bindings/reset/imx7-reset.h | 4 +- 5 files changed, 123 insertions(+), 12 deletions(-)
Signature · 1 line
2.17.1