Skip to content

Object store refactoring: make bitmap_git not global

Jonathan Tan git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2pack-bitmap: remove bitmap_git global variablebuiltin/pack-objects.c builtin/rev-list.c pack-bitmap-write.c +2 more+201 -1583 replies
2/2pack-bitmap: add free functionbuiltin/pack-objects.c builtin/rev-list.c pack-bitmap-write.c +2 more+37 -61 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan BellerBrandon Williams
SeriesR-b
1/2Helped-by
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Object store refactoring: make bitmap_git not global

This is a continuation of the object store refactoring effort.

We cannot truly free an object store without ensuring that any generated bitmaps are first freed, so here are patches to drastically reduce the lifetime of any bitmaps generated. As a bonus, the API is also improved, and global state reduced.

Jonathan Tan (2):
pack-bitmap: remove bitmap_git global variable
pack-bitmap: add free function

 builtin/pack-objects.c |   7 +-
 builtin/rev-list.c     |  13 +-
 pack-bitmap-write.c    |  10 +-
 pack-bitmap.c          | 344 ++++++++++++++++++++++++-----------------
 pack-bitmap.h          |  20 ++-
 5 files changed, 234 insertions(+), 160 deletions(-)
Signature · 1 line
2.17.0.768.g1526ddbba1.dirty