Skip to content

Make unit tests great again

Anatoly Burakov dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7autotest: fix printingtest/test/autotest_runner.py+3 -30 replies
2/7autotest: fix invalid code on reportstest/test/autotest_runner.py+7 -50 replies
3/7autotest: make autotest runner python 2/3 complianttest/test/autotest_runner.py+4 -30 replies
4/7autotest: visually separate different test categoriestest/test/autotest_runner.py+2 -00 replies
5/7autotest: improve filteringtest/test/autotest_runner.py+66 -520 replies
6/7autotest: remove autotest groupingtest/test/autotest.py test/test/autotest_data.py test/test/autotest_runner.py+408 -6190 replies
7/7autotest: properly parallelize unit teststest/test/autotest.py test/test/autotest_runner.py+183 -1000 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchReshma PattanAnatoly Burakov
SeriesR-b R-b R-b R-b R-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] Make unit tests great again

Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script.

In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memory at runtime as needed. This has the implication that the old test grouping can now be retired and replaced with a more sensible way of running unit tests (using multiprocessing pool of workers and a queue of tests). This patchset accomplishes exactly that.

This patchset conflicts with some of the earlier work on autotests [1] [2] [3], but i think it presents a cleaner solution for some of the problems highlighted by those patch series. I can integrate those patches into this series if need be.

[1] http://dpdk.org/dev/patchwork/patch/40370/
[2] http://dpdk.org/dev/patchwork/patch/40371/
[3] http://dpdk.org/dev/patchwork/patch/40372/

Anatoly Burakov (7):
autotest: fix printing
autotest: fix invalid code on reports
autotest: make autotest runner python 2/3 compliant
autotest: visually separate different test categories
autotest: improve filtering
autotest: remove autotest grouping
autotest: properly parallelize unit tests

 test/test/autotest.py        |  13 +-
 test/test/autotest_data.py   | 749 ++++++++++++++---------------------
 test/test/autotest_runner.py | 519 ++++++++++++------------
 3 files changed, 586 insertions(+), 695 deletions(-)
Signature · 1 line
2.17.1