Skip to content

Detect & register virtio-crypto algos only if it can be supported by backend

Farhan Ali kvm linux-crypto lkml qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 5 repliesSuperseded
  3. v1 RFC2 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- Add Christian Borntrager's acks for the patches.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto/virtio-crypto: Read crypto services and algorithm masksdrivers/crypto/virtio/virtio_crypto_common.h drivers/crypto/virtio/virtio_crypto_core.c+43 -00 replies
2/2crypto/virtio-crypto: Register an algo only if it's supporteddrivers/crypto/virtio/virtio_crypto_algs.c drivers/crypto/virtio/virtio_crypto_common.h drivers/crypto/virtio/virtio_crypto_mgr.c+159 -450 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGongleiChristian Borntraeger
1/2A-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Detect & register virtio-crypto algos only if it can be supported by backend

Hi,

Currently the Linux virtio-crypto driver registers the crypto algorithm without verifying if the backend actually supports the algorithm.

This kernel patch series adds support for registering algorithm with Linux crypto layer, only if the algorithm is supported by the backend device. This also makes the driver more compliant with the virtio-crypto spec [1].

I would appreciate any feedback or comments on this.

Thank you
Farhan

Reference
---------
[1] Virtio crypto spec proposal https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg00816.html

ChangeLog
---------
v2 -> v3
- Add Christian Borntrager's acks for the patches.

v1 -> v2
- Modify comment as suggested by Arei (patch 1)
- Modify error message as suggested by Arei (patch 2)

Farhan Ali (2):
crypto/virtio-crypto: Read crypto services and algorithm masks crypto/virtio-crypto: Register an algo only if it's supported

 drivers/crypto/virtio/virtio_crypto_algs.c   | 112 ++++++++++++++++++---------
 drivers/crypto/virtio/virtio_crypto_common.h |  25 +++++-
 drivers/crypto/virtio/virtio_crypto_core.c   |  29 +++++++
 drivers/crypto/virtio/virtio_crypto_mgr.c    |  81 +++++++++++++++++--
 4 files changed, 202 insertions(+), 45 deletions(-)
Signature · 1 line
2.7.4

Read the cover letter in its thread