Skip to content

lan78xx minor fixes

Dave Stevenson netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4net: lan78xx: Allow for VLAN headers in timeout calcsdrivers/net/usb/lan78xx.c+3 -20 replies
2/4net: lan78xx: Add support for VLAN filtering.drivers/net/usb/lan78xx.c+4 -10 replies
3/4net: lan78xx: Add support for VLAN tag stripping.drivers/net/usb/lan78xx.c+22 -00 replies
4/4net: lan78xx: Use s/w csum check on VLANs without tag strippingdrivers/net/usb/lan78xx.c+6 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] lan78xx minor fixes

This is a small set of patches for the Microchip LAN78xx chip, as used in the Raspberry Pi 3B+.
The main debug/discussion was on
https://github.com/raspberrypi/linux/issues/2458

Initial symptoms were that VLANs were very unreliable. A couple of things were found:
- firstly that the hardware timeout value set failed to take into account the VLAN tag, so a full MTU packet would be timed out.
- second was that regular checksum failures were being reported. Disabling checksum offload confirmed that the checksums were valid, and further experimentation identified that it was only if the VLAN tags were being passed through to the kernel that there were issues. The hardware supports VLAN filtering and tag stripping, therefore those have been implemented (much of the work was already done), and the driver drops back to s/w checksums should the choice be made not to use the h/w VLAN stripping.

Dave Stevenson (4):
net: lan78xx: Allow for VLAN headers in timeout calcs
net: lan78xx: Add support for VLAN filtering.
net: lan78xx: Add support for VLAN tag stripping.
net: lan78xx: Use s/w csum check on VLANs without tag stripping

 drivers/net/usb/lan78xx.c | 37 ++++++++++++++++++++++++++++++++++---
 1 file changed, 34 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4