Skip to content

perf: Fixes for callchain ip handling and related tests

Sandipan Das lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5perf powerpc: Fix callchain ip filteringtools/perf/arch/powerpc/util/skip-callchain-idx.c+1 -10 replies
2/5perf powerpc: Fix callchain ip filtering when return address is in a registertools/perf/arch/powerpc/util/skip-callchain-idx.c+6 -20 replies
3/5perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64tools/perf/tests/shell/record+probe_libc_inet_pton.sh+6 -00 replies
4/5perf tests: Fix record+probe_libc_inet_pton.sh to ensure cleanupstools/perf/tests/shell/record+probe_libc_inet_pton.sh+1 -10 replies
5/5perf tests: Fix record+probe_libc_inet_pton.sh when event existstools/perf/tests/shell/record+probe_libc_inet_pton.sh+24 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] perf: Fixes for callchain ip handling and related tests

The first two patches fix the callchain ip filtering mechanism for powerpc from skipping entries unecessarily by checking the status of a function's return address in the stack.

The third patch fixes a shell test that fails on powerpc due to a mismatch in the expected perf script output.

The fourth and fifth patches are generic fixes for the same shell test.

--

Hi Arnaldo,

This series has fixes for the inet_pton shell test and depends on the following patches from Kim Phillips:

[1] https://lkml.org/lkml/2018/6/29/570
[2] https://lkml.org/lkml/2018/6/29/568

I did see that you had replied saying that you have applied these patches to your tree but I still do not see the changes in the 'perf/core' and 'perf/urgent' branches. Assuming that you would be pushing these changes, I applied Kim's patches to my local tree manually before I started working on this series.

--

Sandipan Das (5):
perf powerpc: Fix callchain ip filtering
perf powerpc: Fix callchain ip filtering when return address is in a
register
perf tests: Fix record+probe_libc_inet_pton.sh for powerpc64 perf tests: Fix record+probe_libc_inet_pton.sh to ensure cleanups perf tests: Fix record+probe_libc_inet_pton.sh when event exists

 tools/perf/arch/powerpc/util/skip-callchain-idx.c  | 10 ++++--
 .../tests/shell/record+probe_libc_inet_pton.sh     | 36 +++++++++++++++++++---
 2 files changed, 38 insertions(+), 8 deletions(-)
Signature · 1 line
2.14.4