net/sched: fix NULL dereference in 'goto chain' control action
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | net/sched: act_csum: fix NULL dereference when 'goto chain' is usedinclude/ net/ | +3 | 0 replies | |
| 2/2 | net/sched: act_tunnel_key: fix NULL dereference when 'goto chain' is usedinclude/ net/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net 0/2] net/sched: fix NULL dereference in 'goto chain' control action
in a couple of TC actions (i.e. csum and tunnel_key), the control action is stored together with the action-specific configuration data. This avoids a race condition (see [1]), but it causes a crash when 'goto chain' is used with the above actions. Since this race condition is tolerated on the other TC actions (it's present even on actions where the spinlock is still used), storing the control action in the common area should be acceptable for tunnel_key and csum as well.
[1] https://www.spinics.net/lists/netdev/msg472047.html
Davide Caratti (2):
net/sched: act_csum: fix NULL dereference when 'goto chain' is used net/sched: act_tunnel_key: fix NULL dereference when 'goto chain' is
used
include/net/tc_act/tc_csum.h | 1 - include/net/tc_act/tc_tunnel_key.h | 1 - net/sched/act_csum.c | 6 +++--- net/sched/act_tunnel_key.c | 6 +++--- 4 files changed, 6 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1