Skip to content

/proc/kcore improvements

Omar Sandoval linux-fsdevel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 1 replyIn review
  2. v38 patches 3 repliesSuperseded
  3. v27 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches1 replySuperseded

Changes in v4 from the cover letter

- Fixes a mixed up up_write() instead of up_read() in patch 5 reported by Tetsuo Handa
- Added patch 8 to fix a build failure reported by Stephen Rothwell

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9proc/kcore: don't grab lock for kclist_add()fs/proc/kcore.c include/linux/kcore.h+4 -51 reply
2/9proc/kcore: don't grab lock for memory hotplug notifierfs/proc/kcore.c+2 -40 replies
3/9proc/kcore: replace kclist_lock rwlock with rwsemfs/proc/kcore.c+10 -100 replies
4/9proc/kcore: fix memory hotplug vs multiple opens racefs/proc/kcore.c+44 -490 replies
5/9proc/kcore: hold lock during readfs/proc/kcore.c+40 -300 replies
6/9proc/kcore: clean up ELF header generationfs/proc/kcore.c+141 -2090 replies
7/9proc/kcore: optimize multiple page readsfs/proc/kcore.c+11 -30 replies
8/9crash_core: use VMCOREINFO_SYMBOL_ARRAY() for swapper_pg_dirkernel/crash_core.c+1 -10 replies
9/9proc/kcore: add vmcoreinfo note to /proc/kcorefs/proc/Kconfig fs/proc/kcore.c include/linux/crash_core.h +1 more+21 -40 replies

Reviews trailers per patch

2 of 9 patches have a Reviewed-by or Acked-by.

PatchAndrew Morton
1/9R-b
2/9R-b
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/9] /proc/kcore improvements

From: Omar Sandoval <[email protected]>

Hi,

This series makes a few improvements to /proc/kcore. It fixes a couple of small issues in v3 but is otherwise the same. Patches 1, 2, and 3 are prep patches. Patch 4 is a fix/cleanup. Patch 5 is another prep patch. Patches 6 and 7 are optimizations to ->read(). Patch 8 makes it possible to enable CRASH_CORE on any architecture, which is needed for patch 9. Patch 9 adds vmcoreinfo to /proc/kcore.

Based on v4.18-rc6 + James' patch in the mm tree, and tested with crash and readelf.

Thanks!

Changes from v3:

- Fixes a mixed up up_write() instead of up_read() in patch 5 reported by Tetsuo Handa
- Added patch 8 to fix a build failure reported by Stephen Rothwell

Changes from v2:

- Add __init to kclist_add() as per Andrew
- Got rid of conversion of kcore_need_update from int to atomic_t and just used xchg() instead of atomic_cmpxchg() (split out into a new patch instead of combining it with the rwlock -> rwsem conversion)
- Add comment about the increase in file size to patch 8

Changes from v1:

- Rebased onto v4.18-rc4 + James' patch
(https://patchwork.kernel.org/patch/10519739/) in the mm tree
- Fix spurious sparse warning (see the report and response in
https://patchwork.kernel.org/patch/10512431/)

Omar Sandoval (9):
proc/kcore: don't grab lock for kclist_add() proc/kcore: don't grab lock for memory hotplug notifier proc/kcore: replace kclist_lock rwlock with rwsem proc/kcore: fix memory hotplug vs multiple opens race proc/kcore: hold lock during read
proc/kcore: clean up ELF header generation proc/kcore: optimize multiple page reads
crash_core: use VMCOREINFO_SYMBOL_ARRAY() for swapper_pg_dir proc/kcore: add vmcoreinfo note to /proc/kcore

 fs/proc/Kconfig            |   1 +
 fs/proc/kcore.c            | 534 +++++++++++++++++--------------------
 include/linux/crash_core.h |   2 +
 include/linux/kcore.h      |   2 +-
 kernel/crash_core.c        |   6 +-
 5 files changed, 252 insertions(+), 293 deletions(-)
Signature · 1 line
2.18.0