Skip to content

TC: refactor TC_ACT_REDIRECT action

Paolo Abeni netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tc/act: user space can't use TC_ACT_REDIRECT directlyinclude/uapi/linux/pkt_cls.h net/sched/act_api.c+6 -00 replies
2/4tc/act: remove unneeded RCU lock in action callbackinclude/net/act_api.h include/net/sch_generic.h net/sched/act_bpf.c +8 more+30 -594 replies
3/4net/sched: refactor TC_ACT_REDIRECT handlinginclude/net/sch_generic.h net/core/dev.c net/core/filter.c +3 more+51 -143 replies
4/4act_mirred: use ACT_REDIRECT when possiblenet/sched/act_mirred.c+13 -28 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] TC: refactor TC_ACT_REDIRECT action

This series is aimed at improving the act_mirred redirect performances. Such action is used by OVS to represent TC S/W flows, and it's current largest bottle-neck is the need for a skb_clone() for each packet.

The first 2 patches introduce some cleanup and safeguards to allow changing the TC_ACT_REDIRECT handling: currently the action context is stored in per CPU variables, and we allow also to use the tcf_result. Finally we use this extended infrastructure in act_mirred to implement redirect via TC_ACT_REDIRECT, when possible.

Overall this the above gives a ~10% performance improvement in forwarding tput, when using the TC S/W datapath.

Paolo Abeni (4):
tc/act: user space can't use TC_ACT_REDIRECT directly tc/act: remove unneeded RCU lock in action callback net/sched: refactor TC_ACT_REDIRECT handling
act_mirred: use ACT_REDIRECT when possible

 include/net/act_api.h        |  2 +-
 include/net/sch_generic.h    | 17 ++++++++++++++++-
 include/uapi/linux/pkt_cls.h |  1 +
 net/core/dev.c               |  4 ++--
 net/core/filter.c            | 29 +++++++++++++++++++++++------
 net/core/lwt_bpf.c           |  5 ++++-
 net/sched/act_api.c          |  5 +++++
 net/sched/act_bpf.c          |  8 ++++----
 net/sched/act_csum.c         | 12 +++---------
 net/sched/act_ife.c          |  5 +----
 net/sched/act_mirred.c       | 19 ++++++++++++++-----
 net/sched/act_sample.c       |  4 +---
 net/sched/act_skbedit.c      | 10 +++-------
 net/sched/act_skbmod.c       | 21 +++++++++------------
 net/sched/act_tunnel_key.c   |  6 +-----
 net/sched/act_vlan.c         | 19 +++++++------------
 net/sched/cls_bpf.c          |  8 +++++---
 17 files changed, 100 insertions(+), 75 deletions(-)
Signature · 1 line
2.17.1