Skip to content

Structure and callback cleanups

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7btrfs: remove unused member async_submit_bio::fs_infofs/btrfs/disk-io.c+0 -20 replies
2/7btrfs: remove unused member async_submit_bio::bio_flagsfs/btrfs/disk-io.c+0 -20 replies
3/7btrfs: remove redundant member async_cow::rootfs/btrfs/inode.c+1 -61 reply
4/7btrfs: unify end_io callbacks of async_submit_biofs/btrfs/disk-io.c fs/btrfs/disk-io.h fs/btrfs/extent_io.h +1 more+9 -350 replies
5/7btrfs: drop extent_io_ops::tree_fs_info callbackfs/btrfs/disk-io.c fs/btrfs/extent_io.c fs/btrfs/extent_io.h +1 more+4 -250 replies
6/7btrfs: drop extent_io_ops::merge_bio_hook callbackfs/btrfs/compression.c fs/btrfs/disk-io.c fs/btrfs/extent_io.c +2 more+7 -172 replies
7/7btrfs: drop extent_io_ops::set_range_writeback callbackfs/btrfs/ctree.h fs/btrfs/disk-io.c fs/btrfs/extent_io.c +2 more+4 -150 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNikolay Borisov
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] Structure and callback cleanups

A handful of removed structure members that are not used, async_submit_bio is down by 16 bytes and async_cow by 8.

Some of the extent_io_ops callbacks are unnecessarily called indirectly. The rest of extent_io_ops is going to be transformed in following series.

David Sterba (7):
btrfs: remove unused member async_submit_bio::fs_info
btrfs: remove unused member async_submit_bio::bio_flags
btrfs: remove redundant member async_cow::root
btrfs: unify end_io callbacks of async_submit_bio
btrfs: drop extent_io_ops::tree_fs_info callback
btrfs: drop extent_io_ops::merge_bio_hook callback
btrfs: drop extent_io_ops::set_range_writeback callback

 fs/btrfs/compression.c | 10 +++-------
 fs/btrfs/ctree.h       |  2 +-
 fs/btrfs/disk-io.c     | 42 +++---------------------------------------
 fs/btrfs/disk-io.h     |  5 +++--
 fs/btrfs/extent_io.c   | 28 +++++++---------------------
 fs/btrfs/extent_io.h   |  8 --------
 fs/btrfs/inode.c       | 32 ++++++++------------------------
 7 files changed, 25 insertions(+), 102 deletions(-)
Signature · 1 line
2.18.0