lksctp-tools: fix covscan warnings
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | myftp: fix covscan warningssrc/ | +6 | 0 replies | |
| 2/9 | peel_client: fix covscan warningssrc/ | +4 | 0 replies | |
| 3/9 | peel_server: fix covscan warningssrc/ | +8 | 0 replies | |
| 4/9 | sctp_darn: fix covscan warningssrc/ | +12 | 0 replies | |
| 5/9 | sctp_test: fix covscan warningssrc/ | +13 | 0 replies | |
| 6/9 | sctp_xconnect: fix covscan warningssrc/ | +9 | 0 replies | |
| 7/9 | testlib: fix covscan warningssrc/ | +1 | 0 replies | |
| 8/9 | lib: fix covscan warningssrc/ src/ | +4 | 0 replies | |
| 9/9 | func_tests: fix covscan warningssrc/ src/ src/ +1 more | +4 | 0 replies |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Marcelo Ricardo Leitner |
|---|---|
| Series | A-b |
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH lksctp-tools 0/9] lksctp-tools: fix covscan warnings
This patchset fixes most of the warnings from the covscan of
https://scan.coverity.com/projects/sctp-lksctp-tools
Note that we don't fix these types of warnings:
- getchar() returned value check (medium):
278659 (nowhere uses the returned value)
- call close(-1)/getsockname(-1) (medium):
278617, 278598, 278651, 278594, 278629, 278644, 278620, 278601 (does on purpose)
- DUMPCORE (medium):
278611, 278626, 278653, 278663, 278641, 278591 (does on purpose)
- call mkstemp without securely setting umask first (low):
278636, 278634, 278628, 278616, 278603, 278589, 278647, 278625, 278610
(low priority)- recvsk (high):
278649, 278588 (false positives)
Xin Long (9):
myftp: fix covscan warnings
peel_client: fix covscan warnings
peel_server: fix covscan warnings
sctp_darn: fix covscan warnings
sctp_test: fix covscan warnings
sctp_xconnect: fix covscan warnings
testlib: fix covscan warnings
lib: fix covscan warnings
func_tests: fix covscan warnings
src/apps/myftp.c | 8 ++++++-- src/apps/peel_client.c | 6 ++++-- src/apps/peel_server.c | 11 ++++++++--- src/apps/sctp_darn.c | 15 ++++++++++++--- src/apps/sctp_test.c | 18 +++++++++++++----- src/apps/sctp_xconnect.c | 18 +++++++++--------- src/func_tests/test_1_to_1_rtoinfo.c | 1 + src/func_tests/test_1_to_1_sendto.c | 2 +- src/func_tests/test_sctp_sendrecvmsg.c | 2 +- src/func_tests/test_timetolive.c | 2 +- src/lib/connectx.c | 6 +++--- src/lib/sendmsg.c | 1 + src/testlib/sctputil.c | 1 + 13 files changed, 61 insertions(+), 30 deletions(-)
Signature · 1 line
2.1.0