qga: report serial number and disk node
Status from this message: Thanks, applied to qga tree with some small fix-ups:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest14 patches 2 repliesApplied
- v411 patches 19 repliesSuperseded
- v35 patches 1 replySuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 4 patches | 4 replies | Superseded | |
| v1 | 4 patches | 2 replies | Superseded |
Changes in v5 from the cover letter
- return -1 in PCI info
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | configure: add test for libudevconfigure | +22 | 0 replies | |
| 2/14 | qga: linux: report disk serial numberqga/ qga/ qga/ | +34 | 0 replies | |
| 3/14 | qga: linux: return disk device in guest-get-fsinfoqga/ qga/ | +8 | 0 replies | |
| 4/14 | qga-win: prevent crash when executing fsinfo commandqga/ | +5 | 0 replies | |
| 5/14 | qga-win: fsinfo: pci-info: allow partial infoqga/ | +9 | 0 replies | |
| 6/14 | *additonal fixup for NULL pci_controller fieldqga/ | +4 | 0 replies | |
| 7/14 | build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSIconfigure | +1 | 0 replies | |
| 8/14 | qga-win: add debugging informationdtc qga/ | +16 | 0 replies | |
| 9/14 | qga-win: refactor disk properties (bus)qga/ | +27 | 0 replies | |
| 10/14 | qga-win: report disk serial numberqga/ | +25 | 0 replies | |
| 11/14 | qga-win: refactor disk infoqga/ | +40 | 0 replies | |
| 12/14 | qga-win: handle multi-disk volumesqga/ | +108 | 0 replies | |
| 13/14 | qga-win: return disk device in guest-get-fsinfoqga/ | +11 | 0 replies | |
| 14/14 | qga-win: demystify namespace strippingqga/ | +9 | 0 replies |
Reviews trailers per patch
4 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Marc-André Lureau | Sameeh Jubran |
|---|---|---|---|
| 1/14 | R-b | ||
| 2/14 | |||
| 3/14 | |||
| 4/14 | R-b | ||
| 5/14 | |||
| 6/14 | |||
| 7/14 | R-b | R-b | |
| 8/14 | R-b | ||
| 9/14 | |||
| 10/14 | |||
| 11/14 | |||
| 12/14 | |||
| 13/14 | |||
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v5 00/14] qga: report serial number and disk node
Note that PCI controller reporting on Windows was and still is broken. Unfortunately I don't know how to fix it at the momemnt. See commit message and code comment. If anyone has environment where the original code works let me know. CCing author of the code In case I missed something obvious.
v5:
- return -1 in PCI info
I have cherry-picked three commits from Sameeh Jubran and Michael Roth:
https://github.com/mdroth/qemu/commit/89f145d7e90d721dbc7c9d0082e564bad7e88247
https://github.com/mdroth/qemu/commit/d5f5f7e7dc265a9e62e5f4c2ee342ab7e56cca53
https://github.com/mdroth/qemu/commit/201db36b56d7d1ba5ff720eedcb3b62b75306fde - remove == TRUE from if-conditions
- separate Linux and Windows changes so that the Linux part can be pushed independently; the relevant commits are ordered first.
- fixed several typos
v4:
- split changes into more patches
- fixed UNC for physical drive to use device namespace
- renamed g_debug_err() to debug_error()
- fixed build without libudev
v3:
- fix typos
- add configure test for libudev
- change order of patches fixing PCI controller info and build fix to avoid exposing broken code
- split reporting of serial number and device node into two separate patches
v2:
- fix checkpatch error
Michael Roth (1):
*additonal fixup for NULL pci_controller field
Sameeh Jubran (2):
qga-win: prevent crash when executing fsinfo command
qga-win: fsinfo: pci-info: allow partial info
Tomáš Golembiovský (11):
configure: add test for libudev
qga: linux: report disk serial number
qga: linux: return disk device in guest-get-fsinfo
build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI
qga-win: add debugging information
qga-win: refactor disk properties (bus)
qga-win: report disk serial number
qga-win: refactor disk info
qga-win: handle multi-disk volumes
qga-win: return disk device in guest-get-fsinfo
qga-win: demystify namespace stripping
configure | 24 +++- dtc | 2 +- qga/Makefile.objs | 1 + qga/commands-posix.c | 37 +++++- qga/commands-win32.c | 269 +++++++++++++++++++++++++++++++++++-------- qga/qapi-schema.json | 5 +- 6 files changed, 287 insertions(+), 51 deletions(-)
Signature · 1 line
2.19.0