Skip to content

net: aquantia: implement WOL and EEE support

Igor Russkikh netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 5 repliesIn review
  2. v27 patches 5 repliesSuperseded
  3. v15 patches 8 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net: aquantia: fix hw_atl_utils_fw_upload_dwordsdrivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.h drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_llh_internal.h +3 more+59 -110 replies
2/7net: aquantia: definitions for WOLdrivers/net/ethernet/aquantia/atlantic/aq_nic.h drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c+124 -51 reply
3/7net: aquantia: implement WOL supportdrivers/net/ethernet/aquantia/atlantic/aq_ethtool.c drivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/aq_nic.c +5 more+220 -171 reply
4/7net: aquantia: implement EEE supportdrivers/net/ethernet/aquantia/atlantic/aq_common.h drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c drivers/net/ethernet/aquantia/atlantic/aq_hw.h +4 more+189 -01 reply
5/7net: aquantia: whitespace changesdrivers/net/ethernet/aquantia/atlantic/aq_ethtool.c drivers/net/ethernet/aquantia/atlantic/aq_nic.c drivers/net/ethernet/aquantia/atlantic/aq_ring.c +5 more+49 -490 replies
6/7net: aquantia: renaming for better visibilitydrivers/net/ethernet/aquantia/atlantic/aq_hw.h drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0_internal.h +5 more+52 -640 replies
7/7net: aquantia: bump driver versiondrivers/net/ethernet/aquantia/atlantic/ver.h+1 -10 replies

Reviews trailers per patch

3 of 7 patches have a Reviewed-by or Acked-by.

PatchNikita DanilovAndrew Lunn
1/7T-b
2/7T-b R-b
3/7T-b R-b
4/7T-b R-b
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/7] net: aquantia: implement WOL and EEE support

This is v3 of WOL/EEE functionality patch for atlantic driver.

In this patchset Yana Esina and Nikita Danilov implemented:

- Upload function to interact with FW memory
- Definitions and structures necessary for the correct operation of Wake ON Lan
- The functionality Wake On Lan via ethtool (Magic packet is supported)
- The functionality for Energy-Efficient Ethernet configuration via ethtool

Version 3:
- use ETH_ALEN instead of raw number

Version 2 has the following fixes:
- patchset reorganized to extract renaming and whitespace fixes into separate patches
- some of magic numbers replaced with defines
- reverse christmas tree applied

Discussion outcome regarding driver version bumps was not finished (here https://patchwork.ozlabs.org/patch/954905/)
David, could you suggest the best way to proceed on this?

Igor Russkikh (1):
net: aquantia: bump driver version

Nikita Danilov (2):
net: aquantia: whitespace changes
net: aquantia: renaming for better visibility

Yana Esina (4):
net: aquantia: fix hw_atl_utils_fw_upload_dwords
net: aquantia: definitions for WOL
net: aquantia: implement WOL support
net: aquantia: implement EEE support

 drivers/net/ethernet/aquantia/atlantic/aq_common.h |   5 +
 .../net/ethernet/aquantia/atlantic/aq_ethtool.c    | 113 +++++++++-
 drivers/net/ethernet/aquantia/atlantic/aq_hw.h     |  13 +-
 drivers/net/ethernet/aquantia/atlantic/aq_nic.c    |  24 ++-
 drivers/net/ethernet/aquantia/atlantic/aq_nic.h    |   4 +
 drivers/net/ethernet/aquantia/atlantic/aq_ring.c   |   4 +-
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c  |  41 ++--
 .../aquantia/atlantic/hw_atl/hw_atl_a0_internal.h  |   6 -
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c  |  35 ++--
 .../aquantia/atlantic/hw_atl/hw_atl_b0_internal.h  |   6 -
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c |   8 +
 .../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.h |   3 +
 .../aquantia/atlantic/hw_atl/hw_atl_llh_internal.h |  13 ++
 .../aquantia/atlantic/hw_atl/hw_atl_utils.c        | 163 ++++++++++----
 .../aquantia/atlantic/hw_atl/hw_atl_utils.h        | 130 +++++++++++-
 .../aquantia/atlantic/hw_atl/hw_atl_utils_fw2x.c   | 233 ++++++++++++++++++++-
 drivers/net/ethernet/aquantia/atlantic/ver.h       |   2 +-
 17 files changed, 675 insertions(+), 128 deletions(-)
Signature · 1 line
2.7.4