Skip to content

Another round of tsens cleanups

Amit Kucheria linux-arm-msm linux-devicetree linux-pm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 14 repliesIn review
  2. v211 patches 15 repliesSuperseded
  3. v110 patches 20 repliesSuperseded

Changes in v3 from the cover letter

- Split up changes to code and dt and within dt, split into arm and arm64 patches
- Rearrange the sequence of patches so that the thermal maintainer can pick up the first part and the platform maintainer can pick up the latter part of the series
- Drop patch 09/11 because it causes some issues on systems with non-contiguous enabled sensors e.g. db410c
- Drop patch 10/11 because reg-name property isn't encouraged
- Fix a bug on msm8916 to check if IP is enabled in firmware. This was due to the register being at a different offset on msm8916. Fixed by coding this information as private data.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16thermal: tsens: Prepare 8916 and 8974 tsens to use SROT and TM address spacedrivers/thermal/qcom/tsens-common.c+3 -20 replies
2/16thermal: tsens: Add SPDX license identifiersdrivers/thermal/qcom/tsens-8916.c drivers/thermal/qcom/tsens-8960.c drivers/thermal/qcom/tsens-8974.c +3 more+7 -590 replies
3/16thermal: tsens: Get rid of dead codedrivers/thermal/qcom/tsens.c+0 -50 replies
4/16thermal: tsens: Rename map field in order to add a second address mapdrivers/thermal/qcom/tsens-8960.c drivers/thermal/qcom/tsens-common.c drivers/thermal/qcom/tsens-v2.c +1 more+27 -280 replies
5/16thermal: tsens: Add the SROT address mapdrivers/thermal/qcom/tsens-common.c drivers/thermal/qcom/tsens.h+13 -20 replies
6/16MAINTAINERS: Add entry for Qualcomm TSENS thermal driversMAINTAINERS+7 -00 replies
7/16thermal: tsens: Pass register offsets as private datadrivers/thermal/qcom/tsens-8916.c drivers/thermal/qcom/tsens-8974.c drivers/thermal/qcom/tsens-v2.c +2 more+16 -02 replies
8/16thermal: tsens: Check if the IP is correctly enabled by firmwaredrivers/thermal/qcom/tsens-common.c+17 -00 replies
9/16arm: dts: msm8974: thermal: split address space into twoarch/arm/boot/dts/qcom-msm8974.dtsi+3 -21 reply
10/16arm64: dts: msm8916: thermal: split address space into twoarch/arm64/boot/dts/qcom/msm8916.dtsi+3 -21 reply
11/16arm: dts: msm8974: thermal: Add "qcom,sensors" propertyarch/arm/boot/dts/qcom-msm8974.dtsi+1 -01 reply
12/16arm64: dts: msm8916: thermal: Add "qcom,sensors" propertyarch/arm64/boot/dts/qcom/msm8916.dtsi+1 -01 reply
13/16dt-bindings: thermal: Fix a typo in documentationDocumentation/devicetree/bindings/thermal/thermal.txt+1 -10 replies
14/16arm64: dts: msm8916: Add gpu thermal zonearch/arm64/boot/dts/qcom/msm8916.dtsi+20 -01 reply
15/16arm64: dts: msm8916: Add camera thermal zonearch/arm64/boot/dts/qcom/msm8916.dtsi+21 -01 reply
16/16arm64: dts: sdm845: enable tsens thermal zonesarch/arm64/boot/dts/qcom/sdm845.dtsi+170 -04 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchMatthias KaehlckeBjorn AnderssonRajendra NayakRob HerringAndy Gross
1/16R-b
2/16R-b R-b
3/16R-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b A-b A-b
7/16R-b R-b
8/16R-b
9/16R-b A-b
10/16R-b A-b
11/16R-b R-b A-b
12/16R-b A-b
13/16R-b R-b A-b
14/16A-b
15/16A-b
16/16R-b T-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/16] Another round of tsens cleanups

This is another series of tsens cleanups before we add interrupt support. This applies on top of 4.19-rc2.

Patches [1-6] can directly be applied by Eduardo.
Patches [9-16] can directly be applied by Andy.
Patches [7-8] introduce a new check and needs review and can then be applied completely separately by Eduardo.

There is a *dependency* however. Patch 1 should be applied to the tree before the DT changes in patches 9 and 10.

In this series, I've collected all outstanding tsens patches by combining the patches from the v2 posting with 3 DT patches for sdm845 thermal zones and msm8916 camera and gpu thermal zones. Details are as follows:

- splitup 8916 and 8974 register address spaces for SROT and TM
- cleanups: move to spdx, dead code removal, removal of id field
- Add support to map the SROT address space for DTs that list it separately
- Check if TSENS IP is enabled in firmware by querying the SROT space
- Add myself as maintainer of tsens
- Add one-off patches adding sdm845 thermal zones and msm8916 gpu and camera thermal zones to this series.

Changes since v2:
- Split up changes to code and dt and within dt, split into arm and arm64 patches
- Rearrange the sequence of patches so that the thermal maintainer can pick up the first part and the platform maintainer can pick up the latter part of the series
- Drop patch 09/11 because it causes some issues on systems with non-contiguous enabled sensors e.g. db410c
- Drop patch 10/11 because reg-name property isn't encouraged
- Fix a bug on msm8916 to check if IP is enabled in firmware. This was due to the register being at a different offset on msm8916. Fixed by coding this information as private data.

Changes since v1:
- Split up changes that split the address space and added qcom,sensors property into two separate patches
- Remove brackets in typo correction patch

Amit Kucheria (16):
thermal: tsens: Prepare 8916 and 8974 tsens to use SROT and TM address
space
thermal: tsens: Add SPDX license identifiers
thermal: tsens: Get rid of dead code
thermal: tsens: Rename map field in order to add a second address map
thermal: tsens: Add the SROT address map
MAINTAINERS: Add entry for Qualcomm TSENS thermal drivers
thermal: tsens: Pass register offsets as private data
thermal: tsens: Check if the IP is correctly enabled by firmware
arm: dts: msm8974: thermal: split address space into two
arm64: dts: msm8916: thermal: split address space into two
arm: dts: msm8974: thermal: Add "qcom,sensors" property
arm64: dts: msm8916: thermal: Add "qcom,sensors" property
dt-bindings: thermal: Fix a typo in documentation
arm64: dts: msm8916: Add gpu thermal zone
arm64: dts: msm8916: Add camera thermal zone
arm64: dts: sdm845: enable tsens thermal zones

 .../devicetree/bindings/thermal/thermal.txt   |   2 +-
 MAINTAINERS                                   |   7 +
 arch/arm/boot/dts/qcom-msm8974.dtsi           |   6 +-
 arch/arm64/boot/dts/qcom/msm8916.dtsi         |  47 ++++-
 arch/arm64/boot/dts/qcom/sdm845.dtsi          | 170 ++++++++++++++++++
 drivers/thermal/qcom/tsens-8916.c             |  12 +-
 drivers/thermal/qcom/tsens-8960.c             |  41 ++---
 drivers/thermal/qcom/tsens-8974.c             |  12 +-
 drivers/thermal/qcom/tsens-common.c           |  62 ++++---
 drivers/thermal/qcom/tsens-v2.c               |   8 +-
 drivers/thermal/qcom/tsens.c                  |  19 +-
 drivers/thermal/qcom/tsens.h                  |  23 +--
 12 files changed, 309 insertions(+), 100 deletions(-)
Signature · 1 line
2.17.1