Skip to content

PCI hotplug diet

Lukas Wunner linux-acpi linux-pci linux-s390 linuxppc-dev platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9PCI: Simplify disconnected markingdrivers/pci/hotplug/pciehp_pci.c drivers/pci/pcie/err.c+5 -121 reply
2/9PCI: pciehp: Drop unnecessary includesdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_ctrl.c +2 more+0 -100 replies
3/9PCI: pciehp: Drop hotplug_slot_ops wrappersdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_ctrl.c +1 more+18 -471 reply
4/9PCI: pciehp: Unify controller and slot structsdrivers/pci/hotplug/pciehp.h drivers/pci/hotplug/pciehp_core.c drivers/pci/hotplug/pciehp_ctrl.c +2 more+218 -2908 replies
5/9PCI: pciehp: Reshuffle controller struct for claritydrivers/pci/hotplug/pciehp.h+32 -270 replies
6/9PCI: hotplug: Constify hotplug_slot_opsdrivers/pci/hotplug/acpiphp_core.c drivers/pci/hotplug/cpci_hotplug_core.c drivers/pci/hotplug/cpqphp_core.c +14 more+35 -362 replies
7/9PCI: hotplug: Drop hotplug_slot_infoarch/powerpc/include/asm/pnv-pci.h drivers/pci/hotplug/acpiphp.h drivers/pci/hotplug/acpiphp_core.c +21 more+64 -3403 replies
8/9PCI: hotplug: Embed hotplug_slotdrivers/pci/hotplug/acpiphp.h drivers/pci/hotplug/acpiphp_core.c drivers/pci/hotplug/acpiphp_ibm.c +24 more+223 -3213 replies
9/9PCI: hotplug: Document TODOsdrivers/pci/hotplug/TODO+74 -00 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRafael J. WysockiTyrel DatwylerAndy ShevchenkoSebastian Ott
SeriesA-b
1/9
2/9
3/9
4/9
5/9
6/9R-b A-b
7/9R-b A-b A-b
8/9R-b A-b A-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/9] PCI hotplug diet

Here's PCI hotplug material I've prepared for v4.20:

Patches [1/9] to [8/9] reduce the code by 488 lines. There should be no loss of functionality and no new features, just less and simpler code.

Patch [9/9] collects TODOs for hotplug drivers to spur contributions.

I've assumed that my patch "PCI: pciehp: Differentiate between surprise and safe removal" (submitted July 31) gets merged before this series:
https://patchwork.ozlabs.org/patch/951386/

If that patch is not accepted or other pciehp-related patches are merged before this series, I'll have to rebase patch [4/9] ("PCI: pciehp: Unify controller and slot structs"). No big deal, just a heads-up.

Thanks,

Lukas

Lukas Wunner (9):
PCI: Simplify disconnected marking
PCI: pciehp: Drop unnecessary includes
PCI: pciehp: Drop hotplug_slot_ops wrappers
PCI: pciehp: Unify controller and slot structs
PCI: pciehp: Reshuffle controller struct for clarity
PCI: hotplug: Constify hotplug_slot_ops
PCI: hotplug: Drop hotplug_slot_info
PCI: hotplug: Embed hotplug_slot
PCI: hotplug: Document TODOs

 arch/powerpc/include/asm/pnv-pci.h      |   2 +-
 drivers/pci/hotplug/TODO                |  74 +++++++
 drivers/pci/hotplug/acpiphp.h           |  10 +-
 drivers/pci/hotplug/acpiphp_core.c      |  36 +---
 drivers/pci/hotplug/acpiphp_ibm.c       |   2 +-
 drivers/pci/hotplug/cpci_hotplug.h      |  11 +-
 drivers/pci/hotplug/cpci_hotplug_core.c | 105 +++-------
 drivers/pci/hotplug/cpci_hotplug_pci.c  |   6 +-
 drivers/pci/hotplug/cpqphp.h            |   9 +-
 drivers/pci/hotplug/cpqphp_core.c       |  59 ++----
 drivers/pci/hotplug/cpqphp_ctrl.c       |  31 +--
 drivers/pci/hotplug/ibmphp.h            |   9 +-
 drivers/pci/hotplug/ibmphp_core.c       | 121 ++++-------
 drivers/pci/hotplug/ibmphp_ebda.c       |  70 +------
 drivers/pci/hotplug/pci_hotplug_core.c  |  53 ++---
 drivers/pci/hotplug/pciehp.h            | 138 ++++++-------
 drivers/pci/hotplug/pciehp_core.c       | 127 +++---------
 drivers/pci/hotplug/pciehp_ctrl.c       | 255 +++++++++++-------------
 drivers/pci/hotplug/pciehp_hpc.c        | 127 ++++--------
 drivers/pci/hotplug/pciehp_pci.c        |  24 +--
 drivers/pci/hotplug/pnv_php.c           |  35 ++--
 drivers/pci/hotplug/rpaphp.h            |  10 +-
 drivers/pci/hotplug/rpaphp_core.c       |  20 +-
 drivers/pci/hotplug/rpaphp_pci.c        |  11 +-
 drivers/pci/hotplug/rpaphp_slot.c       |  22 +-
 drivers/pci/hotplug/s390_pci_hpc.c      |  44 ++--
 drivers/pci/hotplug/sgi_hotplug.c       |  63 +++---
 drivers/pci/hotplug/shpchp.h            |   8 +-
 drivers/pci/hotplug/shpchp_core.c       |  48 ++---
 drivers/pci/hotplug/shpchp_ctrl.c       |  21 +-
 drivers/pci/pci.c                       |   4 +-
 drivers/pci/pcie/err.c                  |   8 +-
 drivers/pci/slot.c                      |   2 +-
 drivers/platform/x86/asus-wmi.c         |  39 +---
 drivers/platform/x86/eeepc-laptop.c     |  43 ++--
 include/linux/pci_hotplug.h             |  43 +---
 36 files changed, 638 insertions(+), 1052 deletions(-)
 create mode 100644 drivers/pci/hotplug/TODO
Signature · 1 line
2.18.0