Skip to content

Misc reopen-related patches

Alberto Garcia qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 2 repliesIn review
  2. v210 patches 8 repliesSuperseded
  3. v19 patches 22 repliesSuperseded

Changes in v3 from the cover letter

- Patches 8 and 9: Don't leak the value returned by qemu_opt_get_del()

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10qemu-io: Fix writethrough check in reopenqemu-io-cmds.c+1 -10 replies
2/10file-posix: x-check-cache-dropped should default to false on reopenblock/file-posix.c+1 -10 replies
3/10block: Remove child references from bs->{options, explicit_options}block.c+12 -10 replies
4/10block: Don't look for child references in append_open_options()block.c+1 -120 replies
5/10block: Allow child references on reopenblock.c+18 -00 replies
6/10block: Forbid trying to change unsupported options during reopenblock.c+7 -150 replies
7/10file-posix: Forbid trying to change unsupported options during reopenblock/file-posix.c+7 -20 replies
8/10block: Allow changing 'discard' on reopenblock.c+11 -01 reply
9/10block: Allow changing 'detect-zeroes' on reopenblock.c include/block/block.h+41 -241 reply
10/10block: Allow changing 'force-share' on reopenblock.c include/block/block.h+25 -60 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 00/10] Misc reopen-related patches

Hi,

as part of my blockdev-reopen work here's a new set of patches. This doesn't implement yet the core functionality of the new reopen command, but it does fix a few things that help us pave the way. I believe that the next series after this one will be the last.

The main change is the removal of child references from the options and explicit_options QDicts. This was already discussed in the previous series[1], and here's the implementation.

Regards,

Berto

[1] https://lists.gnu.org/archive/html/qemu-block/2018-08/msg00474.html

v3:
- Patches 8 and 9: Don't leak the value returned by qemu_opt_get_del()

v2: https://lists.gnu.org/archive/html/qemu-block/2018-09/msg00011.html
- Patches 3 and 5: Make comments more explicit. [Max]
- Patch 6: Use qemu_opts_to_qdict() in bdrv_reopen_prepare() to put all unprocessed options back into the QDict. [Max]
- Patches 8-10: Use qemu_opt_get_del() and update commit messages to reflect the changes in patch 6. [Max]

v1: https://lists.gnu.org/archive/html/qemu-block/2018-08/msg00846.html
- Initial version

Output of backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/10:[----] [--] 'qemu-io: Fix writethrough check in reopen' 002/10:[----] [--] 'file-posix: x-check-cache-dropped should default to false on reopen' 003/10:[----] [--] 'block: Remove child references from bs->{options,explicit_options}' 004/10:[----] [--] 'block: Don't look for child references in append_open_options()' 005/10:[----] [--] 'block: Allow child references on reopen'
006/10:[----] [--] 'block: Forbid trying to change unsupported options during reopen' 007/10:[----] [--] 'file-posix: Forbid trying to change unsupported options during reopen' 008/10:[0009] [FC] 'block: Allow changing 'discard' on reopen' 009/10:[0003] [FC] 'block: Allow changing 'detect-zeroes' on reopen' 010/10:[----] [--] 'block: Allow changing 'force-share' on reopen'

Alberto Garcia (10):
qemu-io: Fix writethrough check in reopen
file-posix: x-check-cache-dropped should default to false on reopen
block: Remove child references from bs->{options,explicit_options}
block: Don't look for child references in append_open_options()
block: Allow child references on reopen
block: Forbid trying to change unsupported options during reopen
file-posix: Forbid trying to change unsupported options during reopen
block: Allow changing 'discard' on reopen
block: Allow changing 'detect-zeroes' on reopen
block: Allow changing 'force-share' on reopen

 block.c               | 165 +++++++++++++++++++++++++++++++++-----------------
 block/file-posix.c    |   9 ++-
 include/block/block.h |   2 +
 qemu-io-cmds.c        |   2 +-
 4 files changed, 120 insertions(+), 58 deletions(-)
Signature · 1 line
2.11.0