ethtool: drop get_settings and set_settings ops
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | 8390/etherh: convert to ethtool_{get,set}_link_ksettingsdrivers/ | +19 | 0 replies | |
| 2/2 | ethtool: drop get_settings and set_settings callbacksDocumentation/ include/ include/ +1 more | +50 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH net-next 0/2] ethtool: drop get_settings and set_settings ops
As Andrew Lunn pointed out in recent discussion, there is only one in tree driver left which still defines deprecated callbacks get_settings() and set_settings() in ethtool_ops. First patch converts this driver to get_link_ksettings() and set_link_ksettings(). Second patch then removes the deprecated callbacks from struct ethtool_ops and ethtool code which falls back to them.
This doesn't break old versions of ethtool or any other userspace code using ETHTOOL_{G,S}SET. We still implement both (old) ETHTOOL_{G,S}SET and (new) ETHTOOL_{G,S}LINKSETTINGS ioctl commands but after this series both will be implemented only using {g,s}et_link_ksettings(). The only affected code would be out of tree NIC drivers which have not been converted yet.
Michal Kubecek (2):
8390/etherh: convert to ethtool_{get,set}_link_ksettings
ethtool: drop get_settings and set_settings callbacks
Documentation/ABI/testing/sysfs-class-net | 4 +- drivers/net/ethernet/8390/etherh.c | 35 ++--- include/linux/ethtool.h | 33 ++--- include/uapi/linux/ethtool.h | 15 +- net/core/ethtool.c | 158 +++++----------------- 5 files changed, 69 insertions(+), 176 deletions(-)
Signature · 1 line
2.18.0