Skip to content

Implement new devargs framework

Gaetan Rivet dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 10 repliesIn review
  2. v113 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13bus/pci: implement device iteration and comparisondrivers/bus/pci/Makefile drivers/bus/pci/meson.build drivers/bus/pci/pci_common.c +2 more+86 -40 replies
2/13bus/pci: add device matching field iddrivers/bus/pci/pci_params.c+27 -20 replies
3/13bus/vdev: implement device iterationdrivers/bus/vdev/Makefile drivers/bus/vdev/meson.build drivers/bus/vdev/vdev.c +2 more+89 -60 replies
4/13bus/vdev: add device matching field driverdrivers/bus/vdev/vdev_params.c+13 -23 replies
5/13ethdev: add private generic device iteratorlib/librte_ethdev/Makefile lib/librte_ethdev/ethdev_private.c lib/librte_ethdev/ethdev_private.h +1 more+60 -11 reply
6/13ethdev: register ether layer as a classlib/librte_ethdev/Makefile lib/librte_ethdev/meson.build lib/librte_ethdev/rte_class_eth.c+82 -10 replies
7/13ethdev: add device matching field namelib/librte_ethdev/rte_class_eth.c+7 -03 replies
8/13app/testpmd: add show device commandapp/test-pmd/cmdline.c doc/guides/testpmd_app_ug/testpmd_funcs.rst+78 -00 replies
9/13bus/pci: pre-process declarative PCI devargsdrivers/bus/pci/bsd/pci.c drivers/bus/pci/linux/pci.c drivers/bus/pci/pci_params.c +1 more+77 -00 replies
10/13bus/vdev: pre-process declarative vdev devargsdrivers/bus/vdev/vdev.c drivers/bus/vdev/vdev_params.c drivers/bus/vdev/vdev_private.h+62 -40 replies
11/13bus/pci: process declarative PCI devargsdrivers/bus/pci/pci_common.c drivers/bus/pci/pci_params.c drivers/bus/pci/private.h+23 -00 replies
12/13ethdev: process declarative eth devargslib/librte_ethdev/ethdev_private.h lib/librte_ethdev/rte_class_eth.c lib/librte_ethdev/rte_ethdev.c+84 -01 reply
13/13eal: add generic dev parameterlib/librte_eal/common/eal_common_devargs.c lib/librte_eal/common/eal_common_options.c lib/librte_eal/common/eal_options.h+37 -50 replies

Reviews trailers per patch

5 of 13 patches have a Reviewed-by or Acked-by.

PatchAndrew RybchenkoBernard Iremonger
1/13
2/13
3/13
4/13
5/13A-b
6/13A-b
7/13A-b
8/13A-b
9/13
10/13
11/13
12/13A-b
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] Implement new devargs framework

Last release saw the introduction of the new devargs system. To this end, the "class" abstraction was described as well as a common API for querying and declaring devices.

This patchset implements the "eth" device class and the query/declaration part of the framework for PCI and vdev buses, enabling a minimal support for the new system.

A new testpmd command is added to test device querying.

Devargs parsing is extended in the relevant buses to test device declaration. This part uses the new "rte_eth_dev_create" API, introduced last release and used by only two PMDs, for now.

The new devargs format is also made available through the new --dev parameter.

Next work is to generalize use of new API for eth_dev creation, compatibility layer for -w, -b and --vdev with --dev, and devargs unit test.

--

v2: fixed Andrew's and Stephen's remarks,
added acks.

Gaetan Rivet (13):
bus/pci: implement device iteration and comparison bus/pci: add device matching field id bus/vdev: implement device iteration bus/vdev: add device matching field driver
ethdev: add private generic device iterator
ethdev: register ether layer as a class
ethdev: add device matching field name app/testpmd: add show device command bus/pci: pre-process declarative PCI devargs bus/vdev: pre-process declarative vdev devargs bus/pci: process declarative PCI devargs
ethdev: process declarative eth devargs
eal: add generic dev parameter

 app/test-pmd/cmdline.c                      |  54 +++++++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  24 +++
 drivers/bus/pci/Makefile                    |   3 +-
 drivers/bus/pci/bsd/pci.c                   |   5 +
 drivers/bus/pci/linux/pci.c                 |   5 +
 drivers/bus/pci/meson.build                 |   6 +-
 drivers/bus/pci/pci_common.c                |   6 +-
 drivers/bus/pci/pci_params.c                | 136 +++++++++++++++++
 drivers/bus/pci/private.h                   |  54 +++++++
 drivers/bus/vdev/Makefile                   |   3 +-
 drivers/bus/vdev/meson.build                |   5 +-
 drivers/bus/vdev/vdev.c                     |  20 ++-
 drivers/bus/vdev/vdev_params.c              | 112 ++++++++++++++
 drivers/bus/vdev/vdev_private.h             |  32 ++++
 lib/librte_eal/common/eal_common_devargs.c  |   4 +
 lib/librte_eal/common/eal_common_options.c  |  36 ++++-
 lib/librte_eal/common/eal_options.h         |   2 +
 lib/librte_ethdev/Makefile                  |   4 +-
 lib/librte_ethdev/ethdev_private.c          |  31 ++++
 lib/librte_ethdev/ethdev_private.h          |  31 ++++
 lib/librte_ethdev/meson.build               |   4 +-
 lib/librte_ethdev/rte_class_eth.c           | 158 ++++++++++++++++++++
 lib/librte_ethdev/rte_ethdev.c              |   7 +
 23 files changed, 721 insertions(+), 21 deletions(-)
 create mode 100644 drivers/bus/pci/pci_params.c
 create mode 100644 drivers/bus/vdev/vdev_params.c
 create mode 100644 drivers/bus/vdev/vdev_private.h
 create mode 100644 lib/librte_ethdev/ethdev_private.c
 create mode 100644 lib/librte_ethdev/ethdev_private.h
 create mode 100644 lib/librte_ethdev/rte_class_eth.c
Signature · 1 line
2.18.0