Skip to content

Thunderbolt material for v4.20

Lukas Wunner lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5thunderbolt: Skip disabled ports on tunnel establishmentdrivers/thunderbolt/tb.c+2 -00 replies
2/5thunderbolt: Obtain PCI slot number from DROMdrivers/thunderbolt/eeprom.c drivers/thunderbolt/switch.c drivers/thunderbolt/tb.h+43 -11 reply
3/5thunderbolt: Move upstream_port to struct tbdrivers/thunderbolt/domain.c drivers/thunderbolt/icm.c include/linux/thunderbolt.h+29 -500 replies
4/5thunderbolt: Correlate PCI devices with Thunderbolt portsdrivers/thunderbolt/Makefile drivers/thunderbolt/adapter_pci.c drivers/thunderbolt/adapter_pci.h +2 more+230 -143 replies
5/5MAINTAINERS: Add Lukas Wunner as co-maintainer of thunderboltMAINTAINERS+1 -07 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Thunderbolt material for v4.20

Thunderbolt material for v4.20, comprising:

* A fix to skip disabled ports on tunnel establishment. I am not aware that this has caused breakage in the real world so far, so no need to apply to v4.19 or backport to stable.

* Obtain PCI slot number from DROM and use it to correlate PCI devices with Thunderbolt ports.

* I am nominating myself as co-maintainer, see commit message for the reasons.

Regarding the driver's verbosity which Stephen Hemminger and Mika Westerberg have taken exception to:

* Patch [2/5] logs the PCI slot number as well as data whose purpose is unknown at KERN_INFO severity. I am not opposed to log the former at KERN_DEBUG severity, but the latter must stay at KERN_INFO to allow us to collect the data of various Thunderbolt devices in the wild and reverse-engineer its meaning. If Intel divulges the data's meaning then it need no longer be dumped. This would be ideal for everyone involved.

* Patch [4/5] logs a message at KERN_INFO severity whenever a PCI device correlates or no longer correlates with a Thunderbolt port. I am not opposed to toning this down to KERN_DEBUG, subject to the introduction of tb_port_dbg().

Thanks,

Lukas

Lukas Wunner (5):
thunderbolt: Skip disabled ports on tunnel establishment
thunderbolt: Obtain PCI slot number from DROM
thunderbolt: Move upstream_port to struct tb
thunderbolt: Correlate PCI devices with Thunderbolt ports
MAINTAINERS: Add Lukas Wunner as co-maintainer of thunderbolt

 MAINTAINERS                       |   1 +
 drivers/thunderbolt/Makefile      |   2 +-
 drivers/thunderbolt/adapter_pci.c | 166 ++++++++++++++++++++++++++++++
 drivers/thunderbolt/adapter_pci.h |  19 ++++
 drivers/thunderbolt/domain.c      |  12 +++
 drivers/thunderbolt/eeprom.c      |  21 ++++
 drivers/thunderbolt/icm.c         |  65 +++---------
 drivers/thunderbolt/switch.c      |  14 ++-
 drivers/thunderbolt/tb.c          |  23 ++---
 drivers/thunderbolt/tb.h          |  45 ++++++++
 include/linux/thunderbolt.h       |   2 +
 11 files changed, 305 insertions(+), 65 deletions(-)
 create mode 100644 drivers/thunderbolt/adapter_pci.c
 create mode 100644 drivers/thunderbolt/adapter_pci.h
Signature · 1 line
2.18.0