Skip to content

block/rbd: enable filename parsing on open

Jeff Cody qemu-devel 4 versions Applied

Status from this message: Applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyApplied
  2. v34 patches 2 repliesSuperseded
  3. v23 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches11 repliesSuperseded

Changes in v4 from the cover letter

================

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4block/rbd: pull out qemu_rbd_convert_optionsblock/rbd.c+24 -120 replies
2/4block/rbd: Attempt to parse legacy filenamesblock/rbd.c+51 -20 replies
3/4block/rbd: add iotest for rbd legacy keyvalue filename parsingtests/qemu-iotests/231 tests/qemu-iotests/231.out tests/qemu-iotests/group+72 -00 replies
4/4block/rbd: add deprecation documentation for filename keyvalue pairsqemu-deprecated.texi+15 -00 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchEric BlakeJohn Snow
1/4R-b R-b
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/4] block/rbd: enable filename parsing on open

Changes from v3:
================

Patch 4: Typo fixed [Eric]
Added examples [Eric]

Changes from v2:
=================

Patch 4: New, document deprecation. [Eric]
Patch 3,2: Add r-b's

Changes from v1:
=================

Patch 1: Don't pass unused BlockDriverState to helper function

Patch 2: Do not allow mixed usage; fail if keyvalue is present [Eric]
Add deprecation warning [John]
Pull legacy parsing code into function [John] Fixed filename leak

Patch 3: New; iotest 231. [Eric]

iotest failure on current master:

QA output created by 231
-qemu-img: RBD options encoded in the filename as keyvalue pairs is deprecated. Future versions may cease to parse these options in the future. -unable to get monitor info from DNS SRV with service name: ceph-mon
-no monitors specified to connect to.
-qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': error connecting: No such file or directory +qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': Parameter 'pool' is missing
unable to get monitor info from DNS SRV with service name: ceph-mon
no monitors specified to connect to.
qemu-img: Could not open 'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}': error connecting: No such file or directory
Failures: 231
Failed 1 of 1 tests

Jeff Cody (4):
block/rbd: pull out qemu_rbd_convert_options
block/rbd: Attempt to parse legacy filenames
block/rbd: add iotest for rbd legacy keyvalue filename parsing block/rbd: add deprecation documentation for filename keyvalue pairs

 block/rbd.c                | 89 ++++++++++++++++++++++++++++++++------
 qemu-deprecated.texi       | 15 +++++++
 tests/qemu-iotests/231     | 62 ++++++++++++++++++++++++++
 tests/qemu-iotests/231.out |  9 ++++
 tests/qemu-iotests/group   |  1 +
 5 files changed, 162 insertions(+), 14 deletions(-)
 create mode 100755 tests/qemu-iotests/231
 create mode 100644 tests/qemu-iotests/231.out
Signature · 1 line
2.17.1