Skip to content

EEH refactoring 3

Sam Bobroff linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14powerpc/eeh: Fix possible null deref in eeh_dump_dev_log()arch/powerpc/kernel/eeh.c+5 -01 reply
2/14powerpc/eeh: Fix null deref for devices removed during EEHarch/powerpc/kernel/eeh_driver.c+4 -00 replies
3/14powerpc/eeh: Fix use of EEH_PE_KEEP on wrong fieldarch/powerpc/kernel/eeh_pe.c+1 -10 replies
4/14powerpc/eeh: Cleanup EEH_POSTPONED_PROBEarch/powerpc/include/asm/eeh.h arch/powerpc/kernel/eeh.c arch/powerpc/platforms/powernv/eeh-powernv.c +1 more+7 -270 replies
5/14powerpc/eeh: Cleanup unused field in eeh_devarch/powerpc/include/asm/eeh.h arch/powerpc/kernel/eeh_driver.c+0 -20 replies
6/14powerpc/eeh: Cleanup eeh_add_virt_device()arch/powerpc/kernel/eeh_driver.c+3 -40 replies
7/14powerpc/eeh: Cleanup list_head field namesarch/powerpc/include/asm/eeh.h arch/powerpc/kernel/eeh_dev.c arch/powerpc/kernel/eeh_driver.c +3 more+19 -210 replies
8/14powerpc/eeh: Cleanup field names in eeh_rmv_dataarch/powerpc/kernel/eeh_driver.c+11 -100 replies
9/14powerpc/eeh: Cleanup logic in eeh_rmv_from_parent_pe()arch/powerpc/kernel/eeh_pe.c+2 -20 replies
10/14powerpc/eeh: Cleanup eeh_enabled()arch/powerpc/include/asm/eeh.h+1 -50 replies
11/14powerpc/eeh: Cleanup unnecessary eeh_pe_state_mark_with_cfg()arch/powerpc/kernel/eeh.c arch/powerpc/kernel/eeh_pe.c+4 -240 replies
12/14powerpc/eeh: Cleanup eeh_pe_state_mark()arch/powerpc/include/asm/ppc-pci.h arch/powerpc/kernel/eeh.c arch/powerpc/kernel/eeh_driver.c +3 more+46 -530 replies
13/14powerpc/eeh: Cleanup eeh_ops.wait_state()arch/powerpc/include/asm/eeh.h arch/powerpc/kernel/eeh.c arch/powerpc/kernel/eeh_driver.c +3 more+62 -1080 replies
14/14powerpc/eeh: Cleanup control flow in eeh_handle_normal_event()arch/powerpc/kernel/eeh_driver.c+94 -1020 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] EEH refactoring 3

Hello everyone,

Here is another set of minor fixes and cleanups for the EEH code. There should be no significant changes in behaviour.

I'm not sure if all of these are worth doing, and I don't want to add unnecessary churn so please comment if you have an opinion or better approach.

The set is based on powerpc next.

Cheers,
Sam

Sam Bobroff (14):
powerpc/eeh: Fix possible null deref in eeh_dump_dev_log() powerpc/eeh: Fix null deref for devices removed during EEH powerpc/eeh: Fix use of EEH_PE_KEEP on wrong field powerpc/eeh: Cleanup EEH_POSTPONED_PROBE powerpc/eeh: Cleanup unused field in eeh_dev powerpc/eeh: Cleanup eeh_add_virt_device() powerpc/eeh: Cleanup list_head field names powerpc/eeh: Cleanup field names in eeh_rmv_data powerpc/eeh: Cleanup logic in eeh_rmv_from_parent_pe() powerpc/eeh: Cleanup eeh_enabled()
powerpc/eeh: Cleanup unnecessary eeh_pe_state_mark_with_cfg() powerpc/eeh: Cleanup eeh_pe_state_mark() powerpc/eeh: Cleanup eeh_ops.wait_state() powerpc/eeh: Cleanup control flow in eeh_handle_normal_event()

 arch/powerpc/include/asm/eeh.h               |  24 +-
 arch/powerpc/include/asm/ppc-pci.h           |   1 +
 arch/powerpc/kernel/eeh.c                    |  42 ++--
 arch/powerpc/kernel/eeh_dev.c                |   2 -
 arch/powerpc/kernel/eeh_driver.c             | 237 +++++++++----------
 arch/powerpc/kernel/eeh_pe.c                 | 160 +++++++------
 arch/powerpc/platforms/powernv/eeh-powernv.c |  62 +----
 arch/powerpc/platforms/pseries/eeh_pseries.c |  66 +-----
 arch/powerpc/platforms/pseries/msi.c         |   3 +-
 arch/powerpc/platforms/pseries/pci.c         |   1 +
 drivers/pci/hotplug/pnv_php.c                |   2 +-
 11 files changed, 250 insertions(+), 350 deletions(-)
Signature · 1 line
2.19.0.2.gcad72f5712

Read the cover letter in its thread