Skip to content

Bugfix for partial clones and ref-in-want servers

Jonathan Tan git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fetch-object: provide only one fetching functionfetch-object.c fetch-object.h sha1-file.c +1 more+9 -193 replies
2/2fetch-object: set exact_oid when fetchingfetch-object.c t/t0410-partial-clone.sh+13 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Bugfix for partial clones and ref-in-want servers

A coworker discovered a bug when having a partial clone against a server that supports ref-in-want - the lazy fetches no longer work, because the client attempts to fetch with "want-ref <hash>", which is not permitted by the protocol.

The first patch deduplicates some code, so that the bugfix need only be applied once, and the second patch contains the actual bugfix.

Jonathan Tan (2):
fetch-object: provide only one fetching function
fetch-object: set exact_oid when fetching

 fetch-object.c           | 17 ++++++-----------
 fetch-object.h           |  8 ++------
 sha1-file.c              |  2 +-
 t/t0410-partial-clone.sh | 12 ++++++++++++
 unpack-trees.c           |  2 +-
 5 files changed, 22 insertions(+), 19 deletions(-)
Signature · 1 line
2.19.0.397.gdd90340f6a-goog