Skip to content

Neaten logging uses

Joe Perches linux-scsi lkml 1 version Applied

Status from this message: Applied to 4.20/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7mpt3sas: Add ioc_<level> logging macrosdrivers/scsi/mpt3sas/mpt3sas_base.h+9 -01 reply
2/7mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level>drivers/scsi/mpt3sas/mpt3sas_base.c drivers/scsi/mpt3sas/mpt3sas_config.c drivers/scsi/mpt3sas/mpt3sas_ctl.c +4 more+1533 -19821 reply
3/7mpt3sas: Convert mlsleading uses of pr_<level> with MPT3SAS_FMTdrivers/scsi/mpt3sas/mpt3sas_scsih.c drivers/scsi/mpt3sas/mpt3sas_transport.c+29 -391 reply
4/7mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s:drivers/scsi/mpt3sas/mpt3sas_base.c+5 -51 reply
5/7mpt3sas: Remove KERN_WARNING from panic usesdrivers/scsi/mpt3sas/mpt3sas_config.c+15 -261 reply
6/7mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levelsdrivers/scsi/mpt3sas/mpt3sas_base.c drivers/scsi/mpt3sas/mpt3sas_scsih.c drivers/scsi/mpt3sas/mpt3sas_transport.c+28 -311 reply
7/7mpt3sas: Remove unused macro MPT3SAS_FMTdrivers/scsi/mpt3sas/mpt3sas_base.h+0 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] Neaten logging uses

Several defects exist in the logging uses

o Missing KERN_<LEVEL>
o Unnecessary KERN_<LEVEL> uses with panic
o Mismatched MPT3SAS_FMT and %s: with name and __func__

Correct these defects and perhaps add some clarity to the logging.

Joe Perches (7):
mpt3sas: Add ioc_<level> logging macros
mpt3sas: Convert uses of pr_<level> with MPT3SAS_FMT to ioc_<level>
mpt3sas: Convert mlsleading uses of pr_<level> with MPT3SAS_FMT
mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s:
mpt3sas: Remove KERN_WARNING from panic uses
mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels
mpt3sas: Remove unused macro MPT3SAS_FMT

 drivers/scsi/mpt3sas/mpt3sas_base.c         | 1116 +++++++++-----------
 drivers/scsi/mpt3sas/mpt3sas_base.h         |    9 +-
 drivers/scsi/mpt3sas/mpt3sas_config.c       |   89 +-
 drivers/scsi/mpt3sas/mpt3sas_ctl.c          |  493 ++++-----
 drivers/scsi/mpt3sas/mpt3sas_scsih.c        | 1487 ++++++++++++---------------
 drivers/scsi/mpt3sas/mpt3sas_transport.c    |  337 +++---
 drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c |  101 +-
 drivers/scsi/mpt3sas/mpt3sas_warpdrive.c    |   70 +-
 8 files changed, 1618 insertions(+), 2084 deletions(-)
Signature · 1 line
2.15.0