Skip to content

Fix watchdogd wakeup deferral on RT

Julia Cartwright linux-rt-users linux-watchdog lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2kthread: convert worker lock to raw spinlockinclude/linux/kthread.h kernel/kthread.c+22 -223 replies
2/2watchdog, rt: prevent deferral of watchdogd wakeupdrivers/watchdog/watchdog_dev.c+1 -15 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSteffen TrumtrarGuenter RoeckSebastian Andrzej Siewior
1/2Reported-and-tested-by A-b
2/2Reported-and-tested-by A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] Fix watchdogd wakeup deferral on RT

The following two patches solve an issue reported by Steffen Trumtrar and Tim Sander to the linux-rt-users mailing list. Namely, the wakeup of the watchdogd thread being starved by an RT task due to the hrtimer deferral through ktimersoftd (on PREEMPT_RT_FULL).

The first patch adjusts the kthread_worker locking to make use of a raw spinlock, making it suitable for work item queueing from hardirq context on PREEMPT_RT. This patch can be applied directly to mainline without any functional change.

The second patch adjusts the hrtimer used by the watchdog core to be a _HARD timer (and thus not deferred through ktimersoftd w/ PREEMPT_RT). This patch depends on hrtimer patches carried in the RT patch, and so should therefore land there.

Cc Guenter Roeck <[email protected]>
Cc Steffen Trumtrar <[email protected]>
Cc Tim Sander <[email protected]>

Julia Cartwright (2):
kthread: convert worker lock to raw spinlock watchdog, rt: prevent deferral of watchdogd wakeup

 drivers/watchdog/watchdog_dev.c |  2 +-
 include/linux/kthread.h         |  2 +-
 kernel/kthread.c                | 42 ++++++++++++++++-----------------
 3 files changed, 23 insertions(+), 23 deletions(-)
Signature · 1 line
2.18.0