Skip to content

ARM: dts: imx6sx: Add DISPLAY power domain support

Leonard Crestez dri-devel linux-devicetree linux-pci linux-pm lkml 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 posting 2/21 patch 2 repliesApplied
  2. v2 Latest4 patches 10 repliesApplied
  3. v1 posting 1/23 patches 1 replySuperseded

Changes in v2 from the cover letter

* Document multi-pd in imx6q-pcie bindings and add DT list
* Don't refer to "DISPLAY" as "DISPMIX" because the Reference Manual doesn't do that.
* Link to v1: https://lore.kernel.org/patchwork/cover/994092/

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4soc: imx: gpc: Increase GPC_CLK_MAX to 7drivers/soc/imx/gpc.c+1 -11 reply
2/4dt-bindings: imx6q-pcie: Add multi-pd bindings for imx6sxDocumentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt+3 -11 reply
3/4PCI: imx: Add multi-pd supportdrivers/pci/controller/dwc/pci-imx6.c+48 -02 replies
4/4ARM: dts: imx6sx: Add DISPLAY power domain supportarch/arm/boot/dts/imx6sx.dtsi+18 -15 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchUlf HanssonRob HerringLorenzo Pieralisi
1/4
2/4R-b
3/4R-b A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] ARM: dts: imx6sx: Add DISPLAY power domain support

Now that mxsfb has functional runtime_pm support we can enable power gating for the DISPLAY power domain on imx6sx.

Since pci-imx doesn't support runtime power gating this is still always-on unless PCI is disabled/unused. But it's reasonable for an imx board to not have PCI.

The current pd_pcie is actually only for PCIE_PHY, the PCIE ip block is actually inside the DISPLAY domain. This is handled by adding the pcie node in both power domains, using multi-pd support.

Series is against linux-next. The last patch needs runtime PM in all drivers or it will cause hangs. This means Shawn should hold back on it until the PCI and mxsfb dependencies get merged (both might take a long time). So you can just review that patch and I will resend it later, perhaps in another cycle.

---

Changes since v1:
* Document multi-pd in imx6q-pcie bindings and add DT list
* Don't refer to "DISPLAY" as "DISPMIX" because the Reference Manual doesn't do that.
* Link to v1: https://lore.kernel.org/patchwork/cover/994092/

This is independent of other imx6-pci PM patches such as this one:
* https://lore.kernel.org/patchwork/patch/996806/
Device links are quite nice!

Link to mxsfb thread: https://lkml.org/lkml/2018/9/26/1185

Leonard Crestez (4):
soc: imx: gpc: Increase GPC_CLK_MAX to 7
dt-bindings: imx6q-pcie: Add multi-pd bindings for imx6sx
PCI: imx: Add multi-pd support
ARM: dts: imx6sx: Add DISPLAY power domain support

 .../bindings/pci/fsl,imx6q-pcie.txt           |  4 +-
 arch/arm/boot/dts/imx6sx.dtsi                 | 19 +++++++-
 drivers/pci/controller/dwc/pci-imx6.c         | 48 +++++++++++++++++++
 drivers/soc/imx/gpc.c                         |  2 +-
 4 files changed, 70 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.1