Skip to content

commit-graph: more leak fixes

Martin Ågren git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2commit-graph: free `struct packed_git` after closing itcommit-graph.c+1 -00 replies
2/2builtin/commit-graph.c: UNLEAK variablesbuiltin/commit-graph.c+6 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] commit-graph: more leak fixes

Hi Derrick,

These two patches on top of yours make the test suite (i.e., the subset of it that I run) leak-free with respect to builtin/commit-graph.c and commit-graph.c.

The first could be squashed into your patch 1/2. It touches the same function, but it requires a different usage to trigger, so squashing it in would require broadening the scope. I understand if you don't want to do that.

If you want to pick these up as part of your re-roll in any way, shape or form, go ahead. If not, they can go in separately, either in parallel or after your series lands. Whatever the destiny of this posting, I'll follow through as appropriate.

Martin

Martin Ågren (2):
commit-graph: free struct packed_git after closing it builtin/commit-graph.c: UNLEAK variables

 builtin/commit-graph.c | 11 ++++++-----
 commit-graph.c         |  1 +
 2 files changed, 7 insertions(+), 5 deletions(-)
Signature · 1 line
2.19.0.329.g76f2f5c1e3