Skip to content

phy: ocelot-serdes: fix out-of-bounds read

Gustavo A. R. Silva linux-devicetree lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 0 repliesSuperseded
  3. v12 patches 13 repliesApplied

Changes in v3 from the cover letter

- Post the series to netdev, so Dave can take it.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1include/dt-bindings/phy/phy-ocelot-serdes.h+1 -10 replies
2/2phy: ocelot-serdes: fix out-of-bounds readdrivers/phy/mscc/phy-ocelot-serdes.c+2 -20 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchQuentin SchulzRob Herring
1/2R-b A-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] phy: ocelot-serdes: fix out-of-bounds read

This patchset aims to fix an out-of-bounds bug in
the phy-ocelot-serdes driver.

Currently, there is an out-of-bounds read on array ctrl->phys, once variable i reaches the maximum array size of SERDES_MAX in the for loop.

Quentin Schulz pointed out that SERDES_MAX is a valid value to index ctrl->phys. So, I updated SERDES_MAX to be SERDES6G_MAX + 1 in include/dt-bindings/phy/phy-ocelot-serdes.h.

Then I changed the condition in the for loop from
i <= SERDES_MAX to i < SERDES_MAX in order to
complete the fix.

The reason I'm sending this fix as series is because checkpatch reported an error when I first tried to integrate the whole solution into a singe patch. So, changes to dt-bindings should be sent as a separate patch.

Thanks!

Changes in v3:
- Post the series to netdev, so Dave can take it.

Changes in v2:
- Send the whole series to Kishon Vijay Abraham I, so it can be taken into the PHY tree.
- Add Quentin's Reviewed-by to commit log in both patches.

Gustavo A. R. Silva (2):
dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1
phy: ocelot-serdes: fix out-of-bounds read

 drivers/phy/mscc/phy-ocelot-serdes.c        | 4 ++--
 include/dt-bindings/phy/phy-ocelot-serdes.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4