Skip to content

Fix and improve core RTC function and documentation

Artem Pisarenko qemu-devel 3 versions – Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 4 repliesApplied
  2. v24 patches 2 repliesSuperseded
  3. v14 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- commit messages rewritten/shortened/wrapped to match patch requirements
- fixed minor typo

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4vl: improve/fix documentation related to RTC functionqemu-options.hx+9 -51 reply
2/4vl: refactor -rtc option referencesvl.c+53 -320 replies
3/4Fixes RTC bug with base datetime shifts in clock=vmvl.c+35 -231 reply
4/4vl, qapi: offset calculation in RTC_CHANGE event revertedqapi/misc.json vl.c+7 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/4] Fix and improve core RTC function and documentation

Modifications are motivated by bug https://bugs.launchpad.net/qemu/+bug/1797033 I've encountered recently.

Trying to fix it and analyzing its effect on all use cases (not covered in bug report) revealed much deeper problems.
This is my first patch to QEMU and I'm not sure whether the way I addressed them is proper.
They definitely require either modifications to current implementation (breaking compability), or adding clarifications to user documentation. I've tried to find compromise. Changes I propose are driven mostly by my interpretation of user documentation and comments in code, rather than by existing implementation.

I've splitted patches in a way that at least some of them may be accepted. Following subsets are make sense on their own:
- 1
- 1,2,3

I limited refactoring only to vl.c, although it leads to reworking of all hw/* rtc models which have unreasonable duplications of actions performed by vl.c. I'm sure such kind of rework will reveal more hidden bugs/features, but so far I've had enough (it's a long story how muсh effort and pain cost me to find that tricky bug above). I suppose just to draw attention of relevant hw/* maintainers.

v3 changes:
- commit messages rewritten/shortened/wrapped to match patch requirements
- fixed minor typo
v2 changes:
- fixed compiler warning caused non-debug build fail

Artem Pisarenko (4):
vl: improve/fix documentation related to RTC function
vl: refactor -rtc option references
Fixes RTC bug with base datetime shifts in clock=vm vl,qapi: offset calculation in RTC_CHANGE event reverted

 qapi/misc.json  |   3 +-
 qemu-options.hx |  14 +++++---
 vl.c            | 105 +++++++++++++++++++++++++++++++++++++-------------------
 3 files changed, 80 insertions(+), 42 deletions(-)
Signature · 1 line
2.7.4