Skip to content

Convert floppy drivers to blk-mq

Omar Sandoval linux-block 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest11 patches 3 repliesIn review

Changes in v2 from the cover letter

- Drop "swim3: end whole request on error" and "floppy: end whole request on error".
- Handle errors on individual bios correctly in the other drivers.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11swim: fix cleanup on setup errordrivers/block/swim.c+11 -20 replies
2/11swim: convert to blk-mqdrivers/block/swim.c+49 -521 reply
3/11swim3: add real error handling in setupdrivers/block/swim3.c+36 -240 replies
4/11swim3: convert to blk-mqdrivers/block/swim3.c+75 -880 replies
5/11amiflop: fold headers into C filedrivers/block/amiflop.c include/linux/amifd.h include/linux/amifdreg.h+120 -1480 replies
6/11amiflop: clean up on errors during setupdrivers/block/amiflop.c+40 -440 replies
7/11amiflop: convert to blk-mqdrivers/block/amiflop.c+46 -790 replies
8/11ataflop: fold headers into C filearch/m68k/include/asm/atafd.h arch/m68k/include/asm/atafdreg.h drivers/block/ataflop.c+81 -950 replies
9/11ataflop: fix error handling during setupdrivers/block/ataflop.c+15 -100 replies
10/11ataflop: convert to blk-mqdrivers/block/ataflop.c+81 -1020 replies
11/11floppy: convert to blk-mqdrivers/block/floppy.c+44 -300 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchLaurent Vivier
1/11
2/11A-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] Convert floppy drivers to blk-mq

From: Omar Sandoval <[email protected]>

Hi,

This series converts the various floppy drivers to blk-mq. Save for the last one (floppy), they're compile-tested only. If I've Cc'd you, it's because I think you might be able to test the changes. Please test if you can, or let me know if there's a way to use QEMU/some other emulator to test. The full series is available at [1]. Thanks!

Changes from v1:

- Drop "swim3: end whole request on error" and "floppy: end whole request on error".
- Handle errors on individual bios correctly in the other drivers.

Cc Benjamin Herrenschmidt <[email protected]>
Cc Finn Thain <[email protected]>
Cc Laurent Vivier <[email protected]>

1: https://github.com/osandov/linux/tree/mq-conversions.

Omar Sandoval (11):
swim: fix cleanup on setup error
swim: convert to blk-mq
swim3: add real error handling in setup
swim3: convert to blk-mq
amiflop: fold headers into C file
amiflop: clean up on errors during setup
amiflop: convert to blk-mq
ataflop: fold headers into C file
ataflop: fix error handling during setup
ataflop: convert to blk-mq
floppy: convert to blk-mq

 arch/m68k/include/asm/atafd.h    |  13 --
 arch/m68k/include/asm/atafdreg.h |  80 --------
 drivers/block/amiflop.c          | 328 +++++++++++++++++++------------
 drivers/block/ataflop.c          | 283 +++++++++++++++-----------
 drivers/block/floppy.c           |  74 ++++---
 drivers/block/swim.c             | 114 ++++++-----
 drivers/block/swim3.c            | 219 ++++++++++-----------
 include/linux/amifd.h            |  63 ------
 include/linux/amifdreg.h         |  82 --------
 9 files changed, 590 insertions(+), 666 deletions(-)
 delete mode 100644 arch/m68k/include/asm/atafd.h
 delete mode 100644 arch/m68k/include/asm/atafdreg.h
 delete mode 100644 include/linux/amifd.h
 delete mode 100644 include/linux/amifdreg.h
Signature · 1 line
2.19.1